[8.0.1xx] Use dotnetup preview for SDK acquisition - #55645
Open
nagilson wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
nagilson
force-pushed
the
nagilson/dotnetup-preview-release-8.0.1xx
branch
from
August 6, 2026 19:26
b49777d to
6c007f3
Compare
nagilson
force-pushed
the
nagilson/dotnetup-preview-release-8.0.1xx
branch
from
August 6, 2026 21:59
6c007f3 to
622beb5
Compare
nagilson
marked this pull request as ready for review
August 6, 2026 22:20
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the .NET SDK repo’s toolset/bootstrap scripts on the 8.0.1xx servicing branch to acquire SDKs and test runtimes via dotnetup preview, with shared cross-platform helpers for architecture detection, caching, and download.
Changes:
- Add shared
sdk-tools.*anddotnetup-shared.*helper scripts for architecture detection, musl checks, caching, and dotnetup acquisition. - Use dotnetup in
eng/configure-toolset.*to preinstall the bootstrap SDK pinned inglobal.jsoninto the repo-local.dotnet. - Use dotnetup in
eng/restore-toolset.*to install additional shared frameworks for test execution (with cross-arch sidecar handling and fallback to dotnet-install where needed).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/sdk-tools.sh | Adds bash helpers for native architecture detection (incl. Rosetta) and musl detection. |
| eng/sdk-tools.ps1 | Adds PowerShell helpers for native/process architecture detection. |
| eng/dotnetup-shared.sh | Adds bash helpers to cache/acquire dotnetup and run commands without set -e aborts. |
| eng/dotnetup-shared.ps1 | Adds PowerShell helpers to cache/acquire dotnetup and safely invoke native/scripted installers. |
| eng/configure-toolset.sh | Uses dotnetup to preinstall bootstrap SDK versions into repo-local .dotnet (with fallback behavior). |
| eng/configure-toolset.ps1 | PowerShell equivalent bootstrap SDK acquisition via dotnetup. |
| eng/restore-toolset.sh | Uses dotnetup (or dotnet-install fallback) to install test runtimes; adds cross-arch sidecar logic. |
| eng/restore-toolset.ps1 | PowerShell equivalent test runtime installation and env/shortcut generation updates. |
| .gitignore | Ignores the eng/dotnetup/ dotnetup install/output directory. |
Suppressed comments (1)
eng/restore-toolset.ps1:103
- The generated
sdk-build-env.ps1no longer setsDOTNET_MULTILEVEL_LOOKUP=0, which can allow the build to resolve runtimes/SDKs from global locations. The repo’s toolset scripts set this for hermetic behavior; the generated env script should as well.
`$host.ui.RawUI.WindowTitle = "SDK Build ($RepoRoot)"
# https://aka.ms/vs/unsigned-dotnet-debugger-lib
`$env:VSDebugger_ValidateDotnetDebugLibSignatures=0
`$env:DOTNET_ROOT="$env:DOTNET_INSTALL_DIR"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+135
to
+139
| $scriptPath = Join-Path $ArtifactsDir 'sdk-build-env.ps1' | ||
| $slnPath = Join-Path $RepoRoot 'sdk.slnx' | ||
| $commandToLaunch = "& '$scriptPath'; & '$devenvPath' '$slnPath'" | ||
| $powershellPath = '%SystemRoot%\system32\WindowsPowerShell\v1.0\powershell.exe' | ||
| $shortcutPath = Join-Path $ArtifactsDir 'VS with sdk.slnx.lnk' |
| fi | ||
| done < "$repo_root/global.json" | ||
|
|
||
| local dotnet_root="$repo_root.dotnet" |
| $installScript = GetDotNetInstallScript $dotnetRoot | ||
| & $installScript -Version $version -InstallDir $dotnetRoot -Runtime "dotnet" -SkipNonVersionedFiles | ||
| function Get-VersionDetailsProperty([string]$propertyName) { | ||
| $versionDetailsPath = Join-Path $RepoRoot 'eng\Version.Details.props' |
Comment on lines
79
to
83
| @echo off | ||
| title SDK Build ($RepoRoot) | ||
| set DOTNET_MULTILEVEL_LOOKUP=0 | ||
| REM https://aka.ms/vs/unsigned-dotnet-debugger-lib | ||
| set VSDebugger_ValidateDotnetDebugLibSignatures=0 | ||
|
|
Member
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 3 pipeline(s) were filtered out due to trigger conditions. |
nagilson
force-pushed
the
nagilson/dotnetup-preview-release-8.0.1xx
branch
from
August 7, 2026 20:57
622beb5 to
05a73e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#55640