Fix GetGeneration GC API test failure under interpreter#131918
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…mpatible takes effect Co-authored-by: BrzVlad <4720621+BrzVlad@users.noreply.github.com>
|
/azp run runtime-interpreter |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
|
interpreter tests ran successfully this time |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
BrzVlad
changed the title
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <DebugType>PdbOnly</DebugType> | ||
| <!-- Needed for InterpreterIncompatible, which is only honored by the generated run script --> |
There was a problem hiding this comment.
Where possible, it is better to skip tests for specific configurations using runtime checks or ConditionalFact attributes.
RequiresProcessIsolation makes the test execution less efficient everywhere.
There was a problem hiding this comment.
Also, you can delete SkipOnPlatform(TestPlatforms.Browser, "GC generational behavior differs on browser-wasm")] on the test since it is likely talking about the same issue.
There was a problem hiding this comment.
@copilot Address this review. Use a conditional fact guarded by Utilities.IsCoreClrInterpreter instead.
There was a problem hiding this comment.
@copilot actually, conditional facts might not support negations. Consider SkipOnCoreClr with RuntimeTestModes.InterpreterActive
There was a problem hiding this comment.
@jkotas copilot got stock I think. Pushed the change manually. Left the wasm untouched since my new change doesn't skip on mono-wasm
c636f8f to
838937d
Compare
|
/azp run runtime-interpreter |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
InterpreterIncompatibledid not disableGC/API/GC/GetGenerationunder the interpreterRequiresProcessIsolationtosrc/tests/GC/API/GC/GetGeneration.csprojclr+libsandsrc/tests/build.sh Release -tree:GC/API/GCGetGeneration.shis generated with the interpreter guard and theOutOfProcessTestmarker is emittedDOTNET_InterpMode=1 bash GetGeneration.shskips (exit 0) and a normal run against Core_Root still passes