Skip to content

Add MSBuildTask0012: diagnose tasks constructed without TaskEnvironment propagation - #14813

Open
ViktorHofer with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-task-environment-propagation
Open

Add MSBuildTask0012: diagnose tasks constructed without TaskEnvironment propagation#14813
ViktorHofer with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-task-environment-propagation

Potential fix for pull request finding

67279a6
Select commit
Loading
Failed to load commit list.
Azure Pipelines / msbuild-pr failed Aug 24, 2026 in 48m 29s

Build #20260824.23 had test failures

Details

Tests

  • Failed: 5 (0.01%)
  • Passed: 86,487 (97.87%)
  • Other: 1,880 (2.13%)
  • Total: 88,372

Annotations

Check failure on line 0 in XUnit

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-pr

XUnit#L0

XUnit(0,0): error : Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\Microsoft.Build.Engine.OM.UnitTests_net472_x86.html [net472|x86]

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "**\\*", excludeString: "excludes\\**.*", inputFiles: ["a.cs", "excludes\\b.cs", "excludes\\subdir\\c.cs"], expectedInclude: ["a.cs", "build.proj", "excludes\\b.cs", "excludes\\subdir\\c.cs"])

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-pr

Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "**\\*", excludeString: "excludes\\**.*", inputFiles: ["a.cs", "excludes\\b.cs", "excludes\\subdir\\c.cs"], expectedInclude: ["a.cs", "build.proj", "excludes\\b.cs", "excludes\\subdir\\c.cs"])

System.AggregateException : One or more errors occurred.
---- Assert.Equal() Failure: Values differ
Expected: 2
Actual:   1
---- Assert.Equal() Failure: Values differ
Expected: 2
Actual:   1
Raw output
----- Inner Stack Trace #1 (Xunit.Sdk.EqualException) -----
   at Microsoft.Build.UnitTests.BuildFailureLogInvariant.AssertInvariant(ITestOutputHelper output) in /_/src/UnitTests.Shared/TestEnvironment.cs:line 607
   at Microsoft.Build.UnitTests.TestEnvironment.Cleanup() in /_/src/UnitTests.Shared/TestEnvironment.cs:line 105
   at Microsoft.Build.UnitTests.TestEnvironment.Dispose() in /_/src/UnitTests.Shared/TestEnvironment.cs:line 91
   at Microsoft.Build.UnitTests.ObjectModelHelpers.AssertItemEvaluationFromGenericItemEvaluator(Func`3 itemEvaluator, String projectContents, String[] inputFiles, String[] expectedInclude, Boolean makeExpectedIncludeAbsolute, Dictionary`2[] expectedMetadataPerItem, Boolean normalizeSlashes) in /_/src/UnitTests.Shared/ObjectModelHelpers.cs:line 157
   at Microsoft.Build.UnitTests.ObjectModelHelpers.AssertItemEvaluationFromProject(String projectContents, String[] inputFiles, String[] expectedInclude, Dictionary`2[] expectedMetadataPerItem, Boolean normalizeSlashes, Boolean makeExpectedIncludeAbsolute) in /_/src/UnitTests.Shared/ObjectModelHelpers.cs:line 121
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(String projectContents, String includeString, String excludeString, String[] inputFiles, String[] expectedInclude) in D:\a\_work\1\s\src\Build.OM.UnitTests\Definition\ProjectItem_Tests.cs:line 706
----- Inner Stack Trace #2 (Xunit.Sdk.EqualException) -----
   at Microsoft.Build.UnitTests.BuildFailureLogInvariant.AssertInvariant(ITestOutputHelper output) in /_/src/UnitTests.Shared/TestEnvironment.cs:line 607
   at Microsoft.Build.UnitTests.TestEnvironment.Cleanup() in /_/src/UnitTests.Shared/TestEnvironment.cs:line 105
   at Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.Dispose() in D:\a\_work\1\s\src\Build.OM.UnitTests\Definition\ProjectItem_Tests.cs:line 67
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "**\\*", excludeString: "excludes\\**.*", inputFiles: ["a.cs", "excludes\\b.cs", "excludes\\subdir\\c.cs"], expectedInclude: ["a.cs", "build.proj", "excludes\\b.cs", "excludes\\subdir\\c.cs"])

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-pr

Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "**\\*", excludeString: "excludes\\**.*", inputFiles: ["a.cs", "excludes\\b.cs", "excludes\\subdir\\c.cs"], expectedInclude: ["a.cs", "build.proj", "excludes\\b.cs", "excludes\\subdir\\c.cs"])

Test failed

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "*;**a", excludeString: "**a", inputFiles: ["a"], expectedInclude: ["a", "build.proj"])

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-pr

Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: "*;**a", excludeString: "**a", inputFiles: ["a"], expectedInclude: ["a", "build.proj"])

Test failed

Check failure on line 1 in Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: ":||;||:", excludeString: "||:", inputFiles: [], expectedInclude: [":||"])

See this annotation in the file changed.

@azure-pipelines azure-pipelines / msbuild-pr

Microsoft.Build.UnitTests.OM.Definition.ProjectItem_Tests.ExcludeAndIncludeConsideredAsLiteralsWhenFilespecIsIllegal(projectContents: "\r\n <Project>\r\n "···, includeString: ":||;||:", excludeString: "||:", inputFiles: [], expectedInclude: [":||"])

Test failed