Ship TaskAnalyzer with Microsoft.Build.Framework - #14812
Draft
VolPlita wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Just to double check, I don't think that we wanted to inline the analyzer content into Microsoft.Build.Framework based on recent discussions. It should be enough to just have the analyzer package as a package dependency of Microsoft.Build.Framework. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14078
Context
TaskAnalyzer must be delivered automatically to task authors before it can ship. This change packages the analyzer with
Microsoft.Build.Framework, while retaining the standalone analyzer package for existing partner-repository consumption.Depends on #14811, which establishes the safe default scope and diagnostic severities exercised by the package-consumption tests. Once #14811 merges, this PR will contain only the packaging commit.
Changes Made
Microsoft.Build.TaskAuthoring.Analyzeras a shipping package.Microsoft.Build.Frameworkunderanalyzers/dotnet/cs.Microsoft.Build.Frameworkpackage.scope=allmigration mode, diagnostic suppression, warnings-as-errors, and analyzer opt-out.dotnet buildand bootstrapped MSBuild.Microsoft.Build.Framework.Testing
net11.0andnet472: 4 passed, 0 failed, 0 skipped.Microsoft.Build.Frameworkpackage inspection: exactly one TaskAnalyzer DLL and no bundled or declared Roslyn dependencies.Microsoft.Build.TaskAuthoring.Analyzerpackage generated successfully..\build.cmd -v quiet: passed with 0 warnings and 0 errors.Notes
No packages were published. All package validation used local artifacts.