Add historical binary log replay coverage - #14782
Open
kawmy wants to merge 2 commits into
Open
Conversation
Author
|
@dotnet-policy-service agree |
Author
|
Could a maintainer please rerun the failed Windows checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6587
Context
MSBuild does not currently have focused regression coverage proving that the current
BinaryLogReplayEventSourcecan replay historical binary-log file formats 1 through 14. Without checked-in compatibility fixtures, a reader change could break older.binlogfiles without being detected by the test suite.Changes Made
CanReplayHistoricalBinaryLogFormats, which replays each fixture and verifies:All new test assertions use Shouldly, as recommended by the contribution guide.
Testing
18.10.0-1.26360.111). All 14 fixtures replayed successfully with the expected format version, one project, two targets, and successful completion.Canonical.projsuccessfully with zero warnings and zero errors.git diff --checkpasses.The full
Microsoft.Build.Engine.UnitTestsproject was not restored locally because the isolated environment does not contain its full dependency graph. No bulk package restore was performed; CI should provide the complete project-level validation.Notes
Canonical.projand uses the historical serializer format identified by its filename.