[test-quarantine] Improve reliability of HubConnectionTests.LongPollingUsesHttp2ByDefault - #68222
Draft
vendasankarsf3945 wants to merge 2 commits into
Draft
[test-quarantine] Improve reliability of HubConnectionTests.LongPollingUsesHttp2ByDefault#68222vendasankarsf3945 wants to merge 2 commits into
vendasankarsf3945 wants to merge 2 commits into
Conversation
Contributor
|
Thanks for your PR, @vendasankarsf3945. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve reliability of HubConnectionTests.LongPollingUsesHttp2ByDefault
Description
This PR fixes a flaky failure in
HubConnectionTests.LongPollingUsesHttp2ByDefaultwhen running the LongPolling transport over HTTPS with HTTP/2 enabled.The test already verified the expected negotiate, poll, send, and delete requests, but the teardown path could race with asynchronous log emission. That meant the server could be disposed before the expected HTTP/2 log entries were observed, causing intermittent failures even though the transport behavior was correct.
The fix adds a narrowly scoped synchronization point that waits for the expected HTTP/2 request logs before server disposal and removes the
[QuarantinedTest]attribute from the now-stable test.Validation / Investigation
HubConnectionTests.LongPollingUsesHttp2ByDefaultinHubConnectionTests.cs.Changes
[QuarantinedTest]attribute fromLongPollingUsesHttp2ByDefault.Fixes #50180