Handle DefaultConnectionContext abort/dispose cancellation race - #68146
Open
scarab-systems wants to merge 2 commits into
Open
Handle DefaultConnectionContext abort/dispose cancellation race#68146scarab-systems wants to merge 2 commits into
scarab-systems wants to merge 2 commits into
Conversation
Contributor
|
Thanks for your PR, @scarab-systems. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
scarab-systems
marked this pull request as ready for review
August 1, 2026 03:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Handle DefaultConnectionContext abort/dispose cancellation race
Description
DefaultConnectionContext.Abort()queues cancellation of the connection-closed token on the ThreadPool. If the connection is disposed before that queued work runs, the queuedCancel()can observe a disposedCancellationTokenSourceand raiseObjectDisposedExceptionon the background worker.This change makes the queued cancellation tolerate that already-disposed state. It also adds a
RemoteExecutorregression test that forces the queued cancellation to run afterDisposeAsync().Validation:
./restore.sh --no-build-nodejs --no-build-java --no-build-nativesource ./activate.sh >/dev/null && dotnet test src/Servers/Kestrel/Core/test/Microsoft.AspNetCore.Server.Kestrel.Core.Tests.csproj --no-restore --filter DefaultConnectionContextDisposeAsyncAfterAbortDoesNotCrashProcesssource ./activate.sh >/dev/null && dotnet test src/Servers/Kestrel/Core/test/Microsoft.AspNetCore.Server.Kestrel.Core.Tests.csproj --no-restoreFixes #57098