Resolve correlated aggregates at their outer scope - #3797
Open
fulghum wants to merge 2 commits into
Open
Conversation
|
SummaryCoverage spans grouped and nested data calculations, including correlated values, joins, local-name shadowing, null handling, row counts, large numeric totals, and mixed inner/outer inputs. It includes normal business-logic paths, boundary and edge cases, plus an adversarial check of unsupported array-star behavior, with all exercised behaviors reported healthy. Safe to merge — the exercised query and aggregation behaviors show no regressions or PR-attributable failures, and the unsupported array-star observation is expected behavior rather than a merge blocker. Tests run by Ito
Tip Reply with @itoqa to send us feedback on this test run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Correlated aggregates referenced only inside HAVING subqueries could be registered in the inner query scope. This fed an already-aggregated INT64 result back into an INT32 aggregate buffer and produced a runtime type error.
Pre-register aggregates on their owning outer grouping scope, including aggregates nested beneath scalar functions and valid unqualified references in no-FROM subqueries. Preserve local alias shadowing, mixed local/outer arguments, and independent inner aggregates.
Additional passing and skipped coverage documents adjacent nested semantic-scope behavior. The broader semantic resolver work is tracked by #3814.
Reported by the Doltgres regression comparison: dolthub/doltgresql#3273 (comment)