Refactor and improve DATE parsing and SQL_MODE handling

enginetest/enginetests.go

@@ -4792,19 +4792,17 @@ func TestColumnDefaults(t *testing.T, harness Harness) {
 		}, nil, nil, nil)
 	})
 
-	// TODO: zero timestamps work slightly differently than they do in MySQL, where the zero time is "0000-00-00 00:00:00"
-	//  We use "0000-01-01 00:00:00"
 	t.Run("DATETIME/TIMESTAMP NOW/CURRENT_TIMESTAMP literals", func(t *testing.T) {
 		if IsServerEngine(e) {
 			t.Skip("TODO: fix result formatting for server engine tests")
 		}
-		TestQueryWithContext(t, ctx, e, harness, "CREATE TABLE t10zero(pk BIGINT PRIMARY KEY, v1 DATETIME DEFAULT '2020-01-01 01:02:03', v2 DATETIME DEFAULT 0,"+
-			"v3 TIMESTAMP DEFAULT '2020-01-01 01:02:03', v4 TIMESTAMP DEFAULT 0)", []sql.Row{{types.NewOkResult(0)}}, nil, nil, nil)
+		TestQueryWithContext(t, ctx, e, harness, "CREATE TABLE t10zero(pk BIGINT PRIMARY KEY, v1 DATETIME DEFAULT '2020-01-01 01:02:03', "+
+			"v2 TIMESTAMP DEFAULT '2020-01-01 01:02:03')", []sql.Row{{types.NewOkResult(0)}}, nil, nil, nil)
 
 		RunQueryWithContext(t, e, harness, ctx, "insert into t10zero(pk) values (1)")
 
 		// TODO: the string conversion does not transform to UTC like other NOW() calls, fix this
-		TestQueryWithContext(t, ctx, e, harness, "select * from t10zero order by 1", []sql.Row{{1, time.Date(2020, 1, 1, 1, 2, 3, 0, time.UTC), types.Datetime.Zero(), time.Date(2020, 1, 1, 1, 2, 3, 0, time.UTC), types.Timestamp.Zero()}}, nil, nil, nil)
+		TestQueryWithContext(t, ctx, e, harness, "select * from t10zero order by 1", []sql.Row{{1, time.Date(2020, 1, 1, 1, 2, 3, 0, time.UTC), time.Date(2020, 1, 1, 1, 2, 3, 0, time.UTC)}}, nil, nil, nil)
 	})
 
 	t.Run("Non-DATETIME/TIMESTAMP NOW/CURRENT_TIMESTAMP expression", func(t *testing.T) {

enginetest/evaluation.go

@@ -141,7 +141,7 @@ func TestScriptWithEngine(t *testing.T, e QueryEngine, harness Harness, script q
 					AssertErr(t, e, harness, assertion.Query, assertion.Bindings, assertion.ExpectedErr)
 				} else if assertion.ExpectedErrStr != "" {
 					AssertErrWithCtx(t, e, harness, ctx, assertion.Query, assertion.Bindings, nil, assertion.ExpectedErrStr)
-				} else if assertion.ExpectedWarning != 0 {
+				} else if !assertion.SkipWarnings && assertion.ExpectedWarning != 0 {
 					if IsServerEngine(e) && assertion.SkipResultCheckOnServerEngine {
 						t.Skip()
 					}
@@ -425,7 +425,7 @@ func TestQueryWithEngine(t *testing.T, harness Harness, e QueryEngine, tt querie
 			AssertErr(t, e, harness, tt.Query, tt.Bindings, tt.ExpectedErr)
 		} else if tt.ExpectedErrStr != "" {
 			AssertErrWithCtx(t, e, harness, ctx, tt.Query, tt.Bindings, nil, tt.ExpectedErrStr)
-		} else if tt.ExpectedWarning != 0 {
+		} else if !tt.SkipWarnings && tt.ExpectedWarning != 0 {
 			AssertWarningAndTestQuery(t, e, ctx, harness,
 				tt.Query,
 				tt.Expected,
@@ -574,7 +574,7 @@ func TestPreparedQueryWithEngine(t *testing.T, harness Harness, e QueryEngine, t
 			AssertErr(t, e, harness, tt.Query, tt.Bindings, tt.ExpectedErr)
 		} else if tt.ExpectedErrStr != "" {
 			AssertErrWithCtx(t, e, harness, ctx, tt.Query, tt.Bindings, nil, tt.ExpectedErrStr)
-		} else if tt.ExpectedWarning != 0 {
+		} else if !tt.SkipWarnings && tt.ExpectedWarning != 0 {
 			AssertWarningAndTestPreparedQuery(t, e, ctx, harness, tt.Query, tt.Expected, tt.ExpectedColumns,
 				tt.ExpectedWarning, tt.ExpectedWarningsCount, tt.ExpectedWarningMessageSubstring, false)
 		} else {

enginetest/memory_engine_test.go

@@ -193,30 +193,15 @@ func TestSingleQueryPrepared(t *testing.T) {
 
 // Convenience test for debugging a single query. Unskip and set to the desired query.
 func TestSingleScript(t *testing.T) {
-	t.Skip()
+	//t.Skip()
 	var scripts = []queries.ScriptTest{
 		{
-			Name: "Parse table name as column",
-			SetUpScript: []string{
-				`CREATE TABLE test (pk INT PRIMARY KEY, v1 VARCHAR(255));`,
-				`INSERT INTO test VALUES (1, 'a'), (2, 'b');`,
-			},
+			Name:        "Parse table name as column",
+			SetUpScript: []string{},
 			Assertions: []queries.ScriptTestAssertion{
 				{
-					Query:    "SELECT temporarytesting(t) FROM test AS t;",
-					Expected: []sql.Row{},
-				},
-				{
-					Query:    "SELECT temporarytesting(test) FROM test;",
-					Expected: []sql.Row{},
-				},
-				{
-					Query:    "SELECT temporarytesting(pk, test) FROM test;",
-					Expected: []sql.Row{},
-				},
-				{
-					Query:    "SELECT temporarytesting(v1, test, pk) FROM test;",
-					Expected: []sql.Row{},
+					Query:    `SELECT STR_TO_DATE(FIRST_VALUE(NULL) OVER (), '%Y-%m-%d')`,
+					Expected: []sql.Row{{nil}},
 				},
 			},
 		},
@@ -233,7 +218,7 @@ func TestSingleScript(t *testing.T) {
 		// engine.EngineAnalyzer().Debug = true
 		// engine.EngineAnalyzer().Verbose = true
 
-		enginetest.TestScriptWithEngine(t, engine, harness, test)
+		enginetest.TestScriptWithEnginePrepared(t, engine, harness, test)
 	}
 }