feat(counts): sd-3wp.2 — epic titles and the current epic's roadmap slot - #115
Merged
Conversation
wrap's rewritten session banner names epics and states "epic 2 of 7". counts.json
could supply neither: epics[] carried ids without titles, and its index counts
only live epics, so it cannot express a position among all of them.
Two additive fields, from reads computeRow already makes:
- EpicRow.title — bd's own epic title, via the EpicStatus read the buckets
derive from (bd.EpicRef gains Title to carry it).
- Row.roadmap {k, n} — the current epic's 1-based slot among ALL roadmap ids,
closed included, so k/n reads as progress through the project. Explicit null
when there is no roadmap or no live epic — the same two conditions that null
epics.
Additive only, same rule as #112: every consumer decodes by name into its own
struct, so a key it never mentions cannot affect it.
Verified live against sdlc: roadmap {k:2,n:7}, seven epic titles rendered.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The four lane buckets partition only LIVE children — bd list omits closed — so epics[] could not answer "how far through this epic are we", which the banner's ✓ tally and progress bar both need. EpicRow gains bcl (closed children) and n (total children), taken verbatim from the EpicStatus read epicBuckets already walks. They are bd's own roll-up, not a re-derivation: a nested epic child counts there and not in the buckets, and the comment says so. epicTitles becomes epicMeta — the lookup now carries the whole EpicStatus row rather than just the title. Live against sdlc: sd-ev2 bcl 12 / n 13, matching bd epic status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rewritten wrap session banner (sdlc sd-3wp.2) names epics and states "epic 2 of 7". counts.json could supply neither:
epics[]carried ids without titles, and its index counts only live epics, so it cannot express a position among all of them.What changed
Two additive fields, derived from reads
computeRowalready makes — no new bd forks:EpicRow.title— bd's own epic title, via theEpicStatusread the buckets already derive from.bd.EpicRefgainsTitleto carry it.Row.roadmap {k, n}— the current epic's 1-based slot among all roadmap ids, closed included, sok/nreads as progress through the project. Explicitnullwhen there is no roadmap or no live epic — the same two conditions that nullepics.Compatibility
Additive only, same rule as #112: every consumer decodes by name into its own struct (
bdcounts.Reader, the statusline's jq), so a key it never mentions cannot affect it.Verification
make checkgreen (vet + golangci-lint 0 issues + full test suite + conform).New coverage:
TestRoadmapPos(k/n against all ids incl. closed; the three nil cases),TestEpicTitlesCoversWholeSet, title assertions inTestEpicBucketsandTestComputeRowAssemblesEpicsNextAndClaimed,roadmapadded to both JSON-shape tests.Live against sdlc: