chore(st-w9v): drop counts' eid/epct — two fields with no reader - #114
Merged
Conversation
counts.json has shipped eid and epct per repo since the shell script it
replaced. Nothing has read either key since wrap 0.28.0 removed the statusline's
epic-progress bar ("that display wasn't useful anyway"). Re-grepped across
strand, ~/Projects/sdlc (where the wrap statusline now lives), ~/Projects/cc-
plugins and ~/.claude: the writer was the only mention.
Removes Row.EID/Row.EPct, station(), and the prevEID/prevEPct carry-forward that
threaded a prior row's station through computeRow (st-2fy.7) — computeRow now
takes (ctx, src, root).
strandmd.Roadmap STAYS. The original bead also called the roadmap parse dead;
sd-3wp.1 falsified that half by rewriting it to read ROADMAP.md and giving it
live readers — the epic buckets and the what's-next cascade both derive from it.
Only the two station fields were reader-less.
Dropping keys is safe for the same reason sd-3wp.1's additions were: every
consumer decodes by name into its own struct (bdcounts.Reader) or selects named
keys (the statusline's jq), so a key nobody mentions cannot affect them.
The JSON-shape test now asserts eid/epct are ABSENT, so putting them back has to
be deliberate. Error-path coverage is unchanged: TestComputeRowEpicStatus-
FailureDegradesEpicsAndNext already pins the EpicStatus-failure branch the two
deleted station tests also touched.
Verified on a live repo: `strand counts ~/Projects/sdlc` emits neither key, with
epics and next intact. make check green.
Closes st-w9v
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
counts.jsonhas shippedeidandepctper repo since the shell script it replaced. Nothing has read either key since wrap 0.28.0 removed the statusline's epic-progress bar. Re-grepped across strand,~/Projects/sdlc(where the wrap statusline now lives),~/Projects/cc-pluginsand~/.claude: the writer was the only mention.What goes
Row.EID/Row.EPct,station(), and theprevEID/prevEPctcarry-forward that threaded a prior row's station throughcomputeRow(st-2fy.7).computeRownow takes(ctx, src, root).What stays
strandmd.Roadmap. The bead as originally filed also called the roadmap parse dead — sd-3wp.1 falsified that half by rewriting it to readROADMAP.mdand giving it live readers (the epic buckets and the what's-next cascade both derive from it). Only the two station fields were reader-less, so the bead was rescoped before this work started.Why removing keys is safe
The same reason sd-3wp.1's additions were: every consumer decodes by name into its own struct (
bdcounts.Reader) or selects named keys (the statusline's jq). A key nobody mentions cannot affect them.Tests
The JSON-shape test now asserts
eid/epctare absent, so restoring them has to be deliberate. Error-path coverage is unchanged —TestComputeRowEpicStatusFailureDegradesEpicsAndNextalready pins the EpicStatus-failure branch that the two deleted station tests also touched.Verified on a live repo:
strand counts ~/Projects/sdlcemits neither key, withepicsandnextintact.make checkgreen.Closes st-w9v