Skip to content

chore(st-w9v): drop counts' eid/epct — two fields with no reader - #114

Merged
dkoosis merged 1 commit into
mainfrom
chore/st-w9v-drop-station
Aug 19, 2026
Merged

chore(st-w9v): drop counts' eid/epct — two fields with no reader#114
dkoosis merged 1 commit into
mainfrom
chore/st-w9v-drop-station

Conversation

@dkoosis

@dkoosis dkoosis commented Aug 19, 2026

Copy link
Copy Markdown
Owner

counts.json has shipped eid and epct per repo since the shell script it replaced. Nothing has read either key since wrap 0.28.0 removed the statusline's epic-progress bar. Re-grepped across strand, ~/Projects/sdlc (where the wrap statusline now lives), ~/Projects/cc-plugins and ~/.claude: the writer was the only mention.

What goes

Row.EID / Row.EPct, station(), and the prevEID/prevEPct carry-forward that threaded a prior row's station through computeRow (st-2fy.7). computeRow now takes (ctx, src, root).

What stays

strandmd.Roadmap. The bead as originally filed also called the roadmap parse dead — sd-3wp.1 falsified that half by rewriting it to read ROADMAP.md and giving it live readers (the epic buckets and the what's-next cascade both derive from it). Only the two station fields were reader-less, so the bead was rescoped before this work started.

Why removing keys is safe

The same reason sd-3wp.1's additions were: every consumer decodes by name into its own struct (bdcounts.Reader) or selects named keys (the statusline's jq). A key nobody mentions cannot affect them.

Tests

The JSON-shape test now asserts eid/epct are absent, so restoring them has to be deliberate. Error-path coverage is unchanged — TestComputeRowEpicStatusFailureDegradesEpicsAndNext already pins the EpicStatus-failure branch that the two deleted station tests also touched.

Verified on a live repo: strand counts ~/Projects/sdlc emits neither key, with epics and next intact. make check green.

Closes st-w9v

counts.json has shipped eid and epct per repo since the shell script it
replaced. Nothing has read either key since wrap 0.28.0 removed the statusline's
epic-progress bar ("that display wasn't useful anyway"). Re-grepped across
strand, ~/Projects/sdlc (where the wrap statusline now lives), ~/Projects/cc-
plugins and ~/.claude: the writer was the only mention.

Removes Row.EID/Row.EPct, station(), and the prevEID/prevEPct carry-forward that
threaded a prior row's station through computeRow (st-2fy.7) — computeRow now
takes (ctx, src, root).

strandmd.Roadmap STAYS. The original bead also called the roadmap parse dead;
sd-3wp.1 falsified that half by rewriting it to read ROADMAP.md and giving it
live readers — the epic buckets and the what's-next cascade both derive from it.
Only the two station fields were reader-less.

Dropping keys is safe for the same reason sd-3wp.1's additions were: every
consumer decodes by name into its own struct (bdcounts.Reader) or selects named
keys (the statusline's jq), so a key nobody mentions cannot affect them.

The JSON-shape test now asserts eid/epct are ABSENT, so putting them back has to
be deliberate. Error-path coverage is unchanged: TestComputeRowEpicStatus-
FailureDegradesEpicsAndNext already pins the EpicStatus-failure branch the two
deleted station tests also touched.

Verified on a live repo: `strand counts ~/Projects/sdlc` emits neither key, with
epics and next intact. make check green.

Closes st-w9v
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 27226671-555d-49c6-ba3a-95616dcb6430


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dkoosis
dkoosis merged commit 0e47bc4 into main Aug 19, 2026
2 checks passed
@dkoosis
dkoosis deleted the chore/st-w9v-drop-station branch August 19, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant