-
-
Notifications
You must be signed in to change notification settings - Fork 759
Add file type filtering in slash command attachment options and modal attachment uploads #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
freya022
wants to merge
16
commits into
discord-jda:master
Choose a base branch
from
freya022:feature/attachment-file-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
679d3d5
Add `FileType`
freya022 19cf4eb
Add `IFilterableFileTypes`
freya022 c760c3a
Add file type filtering to slash command options
freya022 9e5f822
Add some methods to test of a file type filters for a specific media …
freya022 78abc35
Add file type filtering for `AttachmentUpload`
freya022 4502e6a
Add a `FileType` container to share logic between slash command optio…
freya022 7a8f117
Show configured file types on `AttachmentUpload`'s `toString`
freya022 4451cd3
Set file types when deserializing/copying options
freya022 3a78480
Document Discord checks extension only and never file content
freya022 1c26d10
Update extension regex
freya022 3eb5355
"if file types are not filtered" -> "if any file is accepted"
freya022 3e0f2ff
"<b>unmodifiable list view</b>" -> "<b>unmodifiable</b> list <b>view<…
freya022 a961484
Merge branch 'refs/heads/master' into feature/attachment-file-types
freya022 c6427a0
Update docs
freya022 42ba9b1
Use empty and immutable file type list if command data doesn't have any
freya022 ab731a5
Don't set `file_types` in `OptionData` if empty
freya022 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
src/main/java/net/dv8tion/jda/api/interactions/FileType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| * Copyright 2015 Austin Keener, Michael Ritter, Florian Spieß, and the JDA contributors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package net.dv8tion.jda.api.interactions; | ||
|
|
||
| import net.dv8tion.jda.internal.utils.Checks; | ||
| import net.dv8tion.jda.internal.utils.EntityString; | ||
| import org.jetbrains.annotations.ApiStatus; | ||
|
|
||
| import java.util.Objects; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| import javax.annotation.Nonnull; | ||
|
|
||
| /** | ||
| * Represents a type of file, you can use presets such as {@link #IMAGE}, | ||
| * or specify an extension using {@link #ofExtension(String)}. | ||
| * | ||
| * <p>Remember that this only checks the extension, Discord does not check for any file signature/MIME type, | ||
| * and thus does not guarantee receiving a valid file. | ||
| */ | ||
| public final class FileType { | ||
| private static final Pattern EXTENSION_PATTERN = Pattern.compile("[\\w\\-.]+"); | ||
|
|
||
| /** Matches any image supported by the Discord client. */ | ||
| public static final FileType IMAGE = new FileType("image"); | ||
| /** Matches any video supported by the Discord client. */ | ||
| public static final FileType VIDEO = new FileType("video"); | ||
| /** Matches any audio supported by the Discord client. */ | ||
| public static final FileType AUDIO = new FileType("audio"); | ||
|
|
||
| private final String value; | ||
|
|
||
| @ApiStatus.Internal | ||
| public FileType(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| /** | ||
| * Creates a {@link FileType} matching the provided extension. | ||
| * | ||
| * @param extension | ||
| * The extension to match against. | ||
| * | ||
| * @throws IllegalArgumentException | ||
| * <ul> | ||
| * <li>If the extension is {@code null} or empty</li> | ||
| * <li>If the extension does not match {@code [\w\-.]+} (latin letters, digits, dashes or dots)</li> | ||
| * </ul> | ||
| * | ||
| * @return The new {@link FileType} | ||
| */ | ||
| @Nonnull | ||
| public static FileType ofExtension(@Nonnull String extension) { | ||
| Checks.matches(extension, EXTENSION_PATTERN, "Extension"); | ||
| return new FileType("." + extension); | ||
| } | ||
|
|
||
| /** | ||
| * Whether this file type accepts all image formats supported by Discord. | ||
| * | ||
| * @return {@code true} if this file type accepts all image formats supported by Discord, {@code false} if not | ||
| */ | ||
| public boolean isImage() { | ||
| return value.equals("image"); | ||
| } | ||
|
|
||
| /** | ||
| * Whether this file type accepts all video formats supported by Discord. | ||
| * | ||
| * @return {@code true} if this file type accepts all video formats supported by Discord, {@code false} if not | ||
| */ | ||
| public boolean isVideo() { | ||
| return value.equals("video"); | ||
| } | ||
|
|
||
| /** | ||
| * Whether this file type accepts all audio formats supported by Discord. | ||
| * | ||
| * @return {@code true} if this file type accepts all audio formats supported by Discord, {@code false} if not | ||
| */ | ||
| public boolean isAudio() { | ||
| return value.equals("audio"); | ||
| } | ||
|
|
||
| /** | ||
| * The raw value of this file type. | ||
| * | ||
| * @return The raw value | ||
| */ | ||
| @Nonnull | ||
| public String getValue() { | ||
| return value; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (!(o instanceof FileType)) { | ||
| return false; | ||
| } | ||
| FileType that = (FileType) o; | ||
| return Objects.equals(value, that.value); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hashCode(value); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return new EntityString(this) | ||
| .setName("FileType") | ||
| .addMetadata("value", value) | ||
| .toString(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this instead of just making it private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in
FileTypesImpl#fromArraywhere the raw value is passed.