Skip to content

fix: sync aria-activedescendant with selection - #411

Open
wanxiankai wants to merge 1 commit into
dip:mainfrom
wanxiankai:fix/aria-activedescendant-sync
Open

fix: sync aria-activedescendant with selection#411
wanxiankai wants to merge 1 commit into
dip:mainfrom
wanxiankai:fix/aria-activedescendant-sync

Conversation

@wanxiankai

Copy link
Copy Markdown

Summary

  • sync selectedItemId from cmdk's item registry when the selected value changes
  • keep the active descendant id available when matching items register during initial render
  • add Playwright coverage for initial and filtered selection aria-activedescendant

Fixes #373

Tests

  • pnpm build
  • pnpm test test/basic.test.ts
  • pnpm test:format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The aria-activedescendant attribute is sometimes missing

1 participant