CCCT-2710: Set New Backup Code screen - #3886
Open
shubham1g5 wants to merge 3 commits into
Open
Conversation
shubham1g5
marked this pull request as draft
August 27, 2026 11:57
shubham1g5
force-pushed
the
ccct-2710-set_new_backup_code
branch
from
August 27, 2026 11:59
f9114bc to
6f7d266
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ccct-2709_confirm_backup_code_profile #3886 +/- ##
===========================================================================
+ Coverage 33.14% 33.20% +0.06%
- Complexity 5906 5921 +15
===========================================================================
Files 1004 1004
Lines 59564 59626 +62
Branches 7124 7129 +5
===========================================================================
+ Hits 19740 19798 +58
- Misses 37575 37577 +2
- Partials 2249 2251 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shubham1g5
force-pushed
the
ccct-2710-set_new_backup_code
branch
3 times, most recently
from
August 28, 2026 09:14
6263093 to
981d926
Compare
shubham1g5
marked this pull request as ready for review
August 28, 2026 09:29
shubham1g5
requested review from
a team and
OrangeAndGreen
and removed request for
a team
August 28, 2026 09:32
4 tasks
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Full implementation of the set-new-backup-code screen: both code and confirm fields visible, validation for match and 6-digit length, biometric unlock via PersonalIdUnlocker.ALWAYS before submission, setRecoveryPin API call, pin stored on success with a success toast, and popBackStack to profile on completion. Also adds personalid_backup_code_changed_success and personalid_set_new_backup_code_title strings in all supported languages (es, fr, ha, hi, lt, no, pt, sw, ti). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Robolectric tests covering: initial UI state (confirm layout visible, button disabled), validation (match/mismatch, length guard, error visibility), successful save (navigates to profile, shows toast, stores updated pin), network error (inline error shown, stays on screen), and unlock failure (no API call, stays on screen). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shubham1g5
force-pushed
the
ccct-2710-set_new_backup_code
branch
from
August 28, 2026 11:37
981d926 to
4a34cd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
https://dimagi.atlassian.net/browse/CCCT-2710
Screen_recording_20260828_144302.mp4
Review Commit by Commit
Safety Assurance
Locally tested end to end and limited impact radius.
Test Coverage
Labels and Review