CCCT-2774 Update Connect Action Bar Icons To New Designs - #3879
CCCT-2774 Update Connect Action Bar Icons To New Designs#3879OrangeAndGreen wants to merge 2 commits into
Conversation
Swap the PersonalID/Connect action bar icons for the new Figma designs, which use Material Symbols Outlined at weight 300, 24px: - Refresh: cloud-with-arrow replaced by the two-arrows-in-a-circle "sync" glyph. Renamed ic_backup -> ic_sync since "backup" no longer describes the artwork, and dropped @color/ic_backup along with it (the deleted drawable was its only consumer; all three menus that show the icon tint it white). - Notifications: new "notifications" / "notifications_unread" bell shapes. The unread badge is now part of the monochrome glyph rather than a separate red circle, and the hand-rolled outline path in ic_new_notification_bell collapses to a single path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Suggested Review Order
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release notes now document updated Connect action bar icons. The bell drawables use Material Symbols notification paths. A new white sync drawable replaces the former backup drawable in the Connect, notification, and work history menus. The obsolete backup drawable and color resource were removed. Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized visual resource update with no behavior or data changes; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
============================================
- Coverage 33.04% 32.98% -0.07%
+ Complexity 5864 5861 -3
============================================
Files 999 999
Lines 59398 59398
Branches 7093 7093
============================================
- Hits 19628 19590 -38
- Misses 37528 37567 +39
+ Partials 2242 2241 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Looks good! Just a minor detail: the icon order in the implementation differs slightly from the design specs. The design places Sync then Notification (left-to-right), whereas the implementation currently has Notification then Sync. I'm not sure if the exact ordering is mandatory. I also noticed the spacing between them is slightly off compared to Figma. |
2 participants
CCCT-2774
Product Description
The refresh and notifications icons in the PersonalID/Connect action bar are updated to the new designs. The refresh icon changes from a cloud-with-arrow to two arrows in a circle, and the notification bell takes on the new outline shape. The unread badge is now part of the bell glyph itself rather than a separate red circle.
Technical Summary
The new icons are Material Symbols Outlined at weight 300, 24px. I confirmed the family by converting the Figma export's coordinates back to the 960 grid and matching them against Google's published
_wght300_24px.svgsources, then generated the drawables from those canonical paths rather than from the Figma clipboard output.Two things worth knowing before reading the diff:
ic_backupis renamed toic_sync, since "backup" no longer describes the artwork.@color/ic_backupwent with it — the deleted drawable was its only consumer, and all three menus that show the icon already tint it white. The menu item IDs (notification_cloud_sync,cloud_sync) still say "cloud"; they're wired into Java/Kotlin so I left them alone.notificationsat the same weight as the read-state counterpart — worth a designer confirm.Safety Assurance
Safety story
What gives confidence:
assembleCommcareDebugpasses and all three vector drawables compile into the APK, which means AAPT accepted the path data.@color/ic_backuphad no other consumer before removing it.Risks to review:
#E44434circle; per Figma it is now white and part of the monochrome glyph. This is a deliberate design change, but it is a visible departure from what ships today and is the thing most likely to draw a "was this intended?" question.ic_bellis also used untinted in the nav drawer footer, which sits on@color/connect_blue_color. I did not exercise the nav drawer with an unread notification, so the unread bell in that surface is unverified.menu_work_history.xmlwas pulled in because it referenced the same drawable. That screen is slightly outside the ticket's stated scope.