Skip to content

Made some changes? (pls dont merge so quickly) - #3

Open
kevkevinpal wants to merge 5 commits into
dillon-co:masterfrom
kevkevinpal:didAThing
Open

Made some changes? (pls dont merge so quickly)#3
kevkevinpal wants to merge 5 commits into
dillon-co:masterfrom
kevkevinpal:didAThing

Conversation

@kevkevinpal

Copy link
Copy Markdown
Contributor

I didnt make changes to the actual component file but I did copy a different lnsocket file and made that small change in index.html

This isn't using the node module but it made this happen

Idk if this is what we wanted or was it supposed to populate with something more?
Screen Shot 2022-03-23 at 7 52 25 PM

@kevkevinpal

Copy link
Copy Markdown
Contributor Author

this isn't using the node module btw it's still in that asset folder

@dillon-co dillon-co left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Thanks for fixing the spacing and single quotes. Good point about not merging quickly haha.

So is lnsocket in the package.json anymore or no?

Comment thread src/app/layout/dashboard/dashboard.component.ts Outdated
@kevkevinpal

Copy link
Copy Markdown
Contributor Author

Looks pretty good. Thanks for fixing the spacing and single quotes. Good point about not merging quickly haha.

So is lnsocket in the package.json anymore or no?

its not in the package.json when I tried importing the lnsocket module it was throwing an error looking for the lnsocket wasm file was trying to fetch it from local host

so I guess we can keep it as an asset till that gets sorted out, rn we're importing it in index.html sill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants