Repository navigation
Let a move back undo an edge crossing jump - #273
Merged
Merged
Conversation
With Cross Unaligned Edges on, a small push past an edge moves the pointer to the other display, often at another height. To get back, you had to find your old spot again. Now Crisp remembers where the pointer was before the jump. If you move back over the same edge while you are still within 150 points of where you landed, the pointer goes back to that spot. If you move further than that, the jump stays. There is no time limit, only the distance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Cross Unaligned Edges on, a small push past an edge moves the pointer to the other display, often at another height. To get back, you had to find your old spot again.
Now Crisp remembers where the pointer was before the jump. If you move back over the same edge while you are still within 150 points of where you landed, the pointer goes back to that spot. If you move further than that, the jump stays. There is no time limit, only the distance.
This follows #184. The rule is
EdgeReturninModels/EdgeCrossing.swift. Its tests cover a move back at the edge, macOS crossing back on its own, the push that caused the jump arriving late, a slide along the edge, and a move too far.