fix(sharing-dialog): support keyboard autocomplete navigation - #1763
Closed
sankorla315 wants to merge 1 commit into
Closed
fix(sharing-dialog): support keyboard autocomplete navigation#1763sankorla315 wants to merge 1 commit into
sankorla315 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow ArrowDown from the SharingDialog autocomplete input to move focus into the results menu
reuse the menu's existing arrow-key navigation and Enter selection behavior
add regression coverage for moving into the menu, navigating down/up, and selecting a result
Keyboard sequence covered by the test: ArrowDown → ArrowDown → ArrowUp → Enter.
Verification
package build completed successfully
changed files pass the repository's ESLint and Prettier checks
git diff --check is clean
Jira: LIBS-571
Related to #1447