Skip to content

Correctly adhere to serialization directives for file generation - #827

Merged
dgarijo merged 1 commit into
dgarijo:developfrom
neeohw:fix-serialization-filenames
Jul 22, 2026
Merged

Correctly adhere to serialization directives for file generation#827
dgarijo merged 1 commit into
dgarijo:developfrom
neeohw:fix-serialization-filenames

Conversation

@neeohw

@neeohw neeohw commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

The file generator doesn't adhere to the filenames in the serialization directives. Which renders the URL's useless as the files won't exist. This PR fixes that.

@dgarijo

dgarijo commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Thanks for your contribution.
I am not very sure of which problem does this PR address. Can you please explain or provide an example?
The serializations are always the same, initialized in the Configuration of the program.
Thanks in advance

@neeohw

neeohw commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

The generator generates serializations with hardcoded file names, but the configuration file allows for indicating the url of the serialization and also the file names. I wanted to make sure that the serializer adheres to these file names if they are configured explicitly. (Which is also what we want in our document generation pipeline.) If it shouldn't be changed here I would like to know what the right procedure is to make sure the serializations can have other file names or aren't generated at all ...

@dgarijo

dgarijo commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Thanks for the explanation, that makes sense :)

@dgarijo
dgarijo merged commit 130d373 into dgarijo:develop Jul 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants