Skip to content

lop-microblaze-riscv: Restore f/d FPU suffix in bsp_archflags #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeddii merged 1 commit into from
Sep 2, 2026
Merged

lop-microblaze-riscv: Restore f/d FPU suffix in bsp_archflags #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lopper/lops/lop-microblaze-riscv.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,10 @@
if not fpu_conflict:
if n['xlnx,use-fpu'].value[0] == 1:
archflags.append('f')
bsp_archflags.append('f')
elif n['xlnx,use-fpu'].value[0] == 2:
archflags.append('d')
bsp_archflags.append('d')
Comment on lines +181 to +184

@zeddii zeddii Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up thought rather than anything to change here: your two lines are the correct fix.

With these restored, every single append in this block writes to both lists: the tune, b, _zicsr_zifencei, _zba, _zbb, _zbs, _zbc, _zicbom, all three -mabi= variants, and now f/d. There is no point where archflags and bsp_archflags are meant to differ — they're identical by construction, kept in step by hand across roughly a dozen paired calls.

That pairing is what allowed the original regression: 22551d46 removed one half of one pair, and nothing could detect it, because the only thing asserting the two lists agree is that someone remembered to type both lines.

Building one list and deriving the other at the join — or just using one, given they're the same string — would make this class of bug unrepresentable rather than merely fixed. Worth a separate patch if you're already in this file.


archflags.insert(0, '-march=')
bsp_archflags.insert(0, '-march=')
Expand Down
Loading