schemas: chosen: allow a boot logo node - #204
Open
maximpedraza0 wants to merge 1 commit into
Open
Conversation
maximpedraza0
force-pushed
the
chosen-logo
branch
from
August 6, 2026 11:10
5528e4d to
971aba9
Compare
A boot logo supplied by firmware is configuration rather than a description of the hardware, so it belongs under /chosen, in the same spirit as the oem-logo variable Open Firmware carried under /options. A Linux binding for such a node is being proposed: https://lore.kernel.org/all/20260804225617.264861-1-maximpedraza@gmail.com/ Allow the node here so that dtbs_check does not reject it. The name is fixed, so it goes in properties rather than patternProperties, and the contents are not validated at this point: the node is matched by its own binding through its compatible string. Signed-off-by: Max Pedraza <maximpedraza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A boot logo supplied by firmware is configuration rather than a description of
the hardware, so it belongs under
/chosen, in the same spirit as theoem-logovariable Open Firmware carried under/options, and in the samecompany as
simple-framebuffer.A Linux binding for such a node,
linux,boot-logo-clut224, is being proposedon the kernel lists:
https://lore.kernel.org/all/20260804225617.264861-1-maximpedraza@gmail.com/
chosen.yamlcurrently allows only^framebufferunder/chosen, sodtbs_checkrejects the node on any board that uses it:This allows it. The name is fixed, so it goes in
propertiesrather thanpatternProperties-- an anchored pattern there is rejected by themetaschema, which says fixed strings belong in
properties. As withframebuffer, the contents are not validated here: the node is matched byits own binding through its compatible string, and the kernel binding pins
the name with
$nodename: const: logo.Tested against two device trees, one carrying the image in the node and one
pointing at a reserved memory region: the error above goes from 1 to 0 on
both, with no other change in
dt-validateoutput.