ENH: Add masking support for many algorithms - #83
Merged
Conversation
No methods currently support masking, so will error if actually used.
Also quant_reg.
Also account for mask when normalizing in mixture_model
Also fixed 2D polynomial setup to not ignore when a mask is given.
Also mark all relevant 2D test classes as supporting masking.
Also set upper bound for amount of masked points.
The items were useless since the actual weights from fitting are contained within method_params['weights']. Marked adaptive_minmax as supporting masking.
Also add mask property to docs.
Owner
Author
|
|
Owner
Author
|
rtd failure is from the masking example, which will be removed/rewritten on the docs branch, so not worth triggering CI again to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mostly addresses issue #72. Adds a new
maskproperty toBaselineandBaseline2Dto allow omitting regions from fitting, and adds test cases to ensure correct behavior. This PR adds mask support for all weighted algorithms (polynomial, Whittaker, and p-spline methods) exceptloess, which will be covered in a separate PR, plus a few optimizers. There are maybe a few other methods that could get mask support without much effort, but they can be added in a later follow up.Type of Pull Request
Pull Request Checklist
if applicable.