Skip to content

fix(audit): remove undocumented tagExclude option (closes #620) - #5304

Open
shoaibyazdani wants to merge 2 commits into
dequelabs:developfrom
shoaibyazdani:fix/remove-tagexclude
Open

fix(audit): remove undocumented tagExclude option (closes #620)#5304
shoaibyazdani wants to merge 2 commits into
dequelabs:developfrom
shoaibyazdani:fix/remove-tagexclude

Conversation

@shoaibyazdani

Copy link
Copy Markdown

What

Removes the undocumented tagExclude option from the public API.

Why

Closes #620. The tagExclude option was undocumented and provided no real value beyond filtering rules by internal tags. Removing it simplifies the public API and removes a maintenance burden.

Changes

  • Removed this.tagExclude = ['experimental', 'deprecated'] default in audit.js
  • Removed spec.tagExclude handling in configure.js
  • Removed tagExclude filtering in get-rules.js
  • Removed defaultExclude logic in rule-should-run.js
  • Removed/updated tests that depended on tagExclude
  • 9 files changed, 4 insertions(+), 304 deletions(-)

Closes: #620

@shoaibyazdani
shoaibyazdani requested a review from a team as a code owner August 10, 2026 05:19
@CLAassistant

CLAassistant commented Aug 10, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shoaibyazdani
❌ Shoaib Latif


Shoaib Latif seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

The tagExclude option was undocumented and provided no real value
beyond filtering rules by internal tags. Removing it simplifies the
public API and removes a maintenance burden.

- Removed `this.tagExclude = ['experimental', 'deprecated']` default
- Removed `spec.tagExclude` handling in configure
- Removed tagExclude filtering in get-rules
- Removed defaultExclude logic in rule-should-run
- Removed/updated tests that depended on tagExclude
@shoaibyazdani
shoaibyazdani force-pushed the fix/remove-tagexclude branch from 30a0b0a to 538bd70 Compare August 10, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the undocumented tagExclude option

2 participants