fix(audit): remove undocumented tagExclude option (closes #620) - #5304
Open
shoaibyazdani wants to merge 2 commits into
Open
fix(audit): remove undocumented tagExclude option (closes #620)#5304shoaibyazdani wants to merge 2 commits into
shoaibyazdani wants to merge 2 commits into
Conversation
|
Shoaib Latif seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The tagExclude option was undocumented and provided no real value beyond filtering rules by internal tags. Removing it simplifies the public API and removes a maintenance burden. - Removed `this.tagExclude = ['experimental', 'deprecated']` default - Removed `spec.tagExclude` handling in configure - Removed tagExclude filtering in get-rules - Removed defaultExclude logic in rule-should-run - Removed/updated tests that depended on tagExclude
shoaibyazdani
force-pushed
the
fix/remove-tagexclude
branch
from
August 10, 2026 05:46
30a0b0a to
538bd70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the undocumented
tagExcludeoption from the public API.Why
Closes #620. The
tagExcludeoption was undocumented and provided no real value beyond filtering rules by internal tags. Removing it simplifies the public API and removes a maintenance burden.Changes
this.tagExclude = ['experimental', 'deprecated']default in audit.jsspec.tagExcludehandling in configure.jstagExcludefiltering in get-rules.jsdefaultExcludelogic in rule-should-run.jsCloses: #620