Revert "feat: add node-builtin-specifier rule (#1306)" - #1532
Merged
Conversation
This reverts commit d42bc49.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the
node-builtin-specifierrule (#1306).The rule hardcodes its own copy of the Node.js built-in module list,
which has to be kept in sync by hand and inevitably drifts from the set
of modules Deno actually supports. That canonical list already lives in
the Deno repo under
ext/node(exposed asDENO_SUPPORTED_BUILTIN_NODE_MODULES), so the rule is being moved thereand reimplemented on top of it. Keeping it in deno_lint would mean
maintaining a second, divergent source of truth.
The rule is reintroduced in denoland/deno as an extended CLI lint rule
that reuses the existing built-in module list: denoland/deno#35628.