feat(no-useless-fallback-in-spread): add no-useless-fallback-in-spread rule - #1527
Open
bartlomieju wants to merge 1 commit into
Open
feat(no-useless-fallback-in-spread): add no-useless-fallback-in-spread rule#1527bartlomieju wants to merge 1 commit into
no-useless-fallback-in-spread rule#1527bartlomieju wants to merge 1 commit into
Conversation
Member
Author
|
Verdict: LGTM — correct and well-tested. Recommend merge after the RECOMMENDED sign-off you flagged + rebase. Not auto-merging (new rule). Clean port; flags Correctness — verified
Perf: trivial — per Housekeeping: No code changes requested — the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the unicorn
no-useless-fallback-in-spreadrule from oxlint as anative deno_lint rule.
The rule flags a useless empty-object fallback inside an object spread, such as
{ ...(foo || {}) }or{ ...(foo ?? {}) }. Spreading a nullish (or otherwisefalsy) value into an object literal is a no-op, so providing an empty object
{}as a fallback via||or??adds nothing and can be removed. The ruleonly triggers when the spread is inside an object literal (not an array literal
or call arguments), the logical operator is
||or??, and the right operandis an empty object literal, unwrapping any surrounding parentheses to match
oxc's behavior.
Reference implementation:
https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules/unicorn/no_useless_fallback_in_spread.rs
Tagged RECOMMENDED (on by default) — flagging for maintainer sign-off.