feat(prefer-set-size): add prefer-set-size rule - #1525
Open
bartlomieju wants to merge 1 commit into
Open
Conversation
Member
Author
|
Verdict: LGTM — correct and well-tested. Recommend merge after the RECOMMENDED sign-off you flagged + rebase. Not auto-merging (new rule). Careful two-pass port (collect Correctness — verified
Perf: two full traversals (collector + handler), each O(nodes), with O(1) Housekeeping: No code changes requested — the const-only soundness and the exclusion set are exactly right. Just tagging + rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the
prefer-set-sizerule from oxlint's unicorn plugin as a nativeRust rule.
The rule flags a
.lengthmember access on an array produced by converting aSetto an array, and recommends usingSet#sizeinstead. It catches bothspread conversions (
[...set].length) andArray.from(set).length, where theSetis either a directnew Set(...)or aconst-declared variableinitialized to
new Set(...).It deliberately does not flag: optional chaining (
?.length), computed access(
[length]/["length"]), non-lengthproperties,new NotSet(...), bareSet(...)withoutnew,let/var-declared or destructured set variables,Array.from(set, mapFn)(a second map-fn argument),Array?.from/Array.from?.(), andNotArray.from.The pass/fail fixtures are ported verbatim from the oxc reference rule:
https://github.com/oxc-project/oxc/blob/main/crates/oxc_linter/src/rules/unicorn/prefer_set_size.rs
(the autofix-only fixtures are dropped since deno_lint has no autofixer here).
Tagged RECOMMENDED (on by default) — flagging for maintainer sign-off.