Skip to content

fix(no-implicit-declare-namespace-export): skip declare global #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fibibot wants to merge 1 commit into from
Closed

fix(no-implicit-declare-namespace-export): skip declare global #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/rules/no_implicit_declare_namespace_export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ impl Handler for NoImplicitDeclareNamespaceExportHandler {
module_decl: &ast_view::TsModuleDecl,
ctx: &mut Context,
) {
if module_decl.inner.declare {
// `declare global { ... }` is a module augmentation and cannot contain
// `export { ... }` or `export {}`, so the hint this rule emits would only
// swap one error for another. Skip it.
if module_decl.inner.declare && !module_decl.inner.global {
if let Some(ast_view::TsNamespaceBody::TsModuleBlock(block)) =
module_decl.body
{
Expand Down Expand Up @@ -109,6 +112,20 @@ declare namespace bar {
r#"
declare namespace empty {}
"#,
// `declare global { ... }` is a module augmentation; `export {};` is a
// syntax error inside it, so the rule must not fire here.
// See https://github.com/denoland/deno/issues/33268.
r#"
declare global {
const asdf: number;
}
"#,
r#"
declare global {
interface X {}
const FOO: string;
}
"#,
};

assert_lint_ok! {
Expand Down