feat(desktop): forward flags to underlying laufey executable - #36384
feat(desktop): forward flags to underlying laufey executable#36384iownbey wants to merge 6 commits into
Conversation
Deno Individual Contributor License AgreementAll contributors have signed the CLA. Thank you! This is an automated message from CLA Assistant |
|
Thanks for this, and for the clear write-up in the issue — being unable to configure CEF is a real gap we want to close. The concern with the current approach is that Could we instead add a dedicated Two things that would make it complete:
For tests, a spec test in |
|
Seeing if my draft passes ci. If it does I'll do a cleanup pass. "backend": "cef"
"backendArgs": {
"cef": "..args..."
}Let me know if you want to go with a different approach |
|
spec tests are failing in ci, not locally, looks like its related to virtual desktops. I'll be able to investigate more in a few days |
On macOS the compiled desktop runtime is hello3.dylib (not hello3.so), so the "forwards_backend_flags_to_launcher_hmi" step needs a separate expected output file for mac. Add desktop_hmi_mac.out and point the mac step at it, leaving the linux step on desktop_hmi.out.
#36031
Open to a different approach if you guys have any suggestions, but this seemed like a really simple way to unlock a lot of chromium functionality. I built and tested deno to check that this let me use this with hmr and the built executable
AI was used to write this PR