-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add an opt-in DeepEP transport for the AutoEP expert all-to-all #8213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yh0903
wants to merge
14
commits into
deepspeedai:master
Choose a base branch
from
yh0903:autoep-deepep-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,018
−6
Open
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cbaa06e
Add an opt-in DeepEP transport for the AutoEP expert all-to-all
yh0903 e566d6f
Merge branch 'master' into autoep-deepep-backend
hwchen2017 79a6ea0
Address review feedback on the DeepEP backend
yh0903 12feb41
Drop the exchange field the weights no longer travel through
yh0903 d2071c0
Agree DeepEP buffer capacity across the group and trim weights with rows
yh0903 e6fbaf9
Address maintainer review on the DeepEP backend
yh0903 615461f
Cut dispatch buffers to the arrivals the handle records
yh0903 ab4e7cc
Agree the DeepEP buffer size once per shape rather than per layer
yh0903 b86750a
Re-measure the SM budget and the end-to-end speedup
yh0903 7c67643
Quote the typical run rather than the fastest one
yh0903 2805733
Size the DeepEP buffer once and add a parity test against the collect…
yh0903 4d37a23
Quote the speedup as reproduced rather than as one job's best
yh0903 b787690
Merge branch 'master' into autoep-deepep-backend
delock 2f636d2
Trim the longest AutoEP DeepEP comments to their conclusions
yh0903 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DeepEP's dispatch kernel doesn't work with FP16, but the code can reach here. Can we reject FP16 settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added a dtype check at the start of
_deepep_route. FP16 now fails before buffer construction or dispatch, with an error pointing users to bfloat16 orcomm_backend="comm".