Skip to content

Bump version: 2.0.0 → 2.0.1 + new regex - #185

Merged
Agustin-Picard merged 1 commit into
masterfrom
release/2.0.1
Aug 28, 2026
Merged

Bump version: 2.0.0 → 2.0.1 + new regex#185
Agustin-Picard merged 1 commit into
masterfrom
release/2.0.1

Conversation

@AntoninPoche

@AntoninPoche AntoninPoche commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Initially, I had the wrong order and tried to bump the version after the merge, which forced me to create a new PR.

However, through the PR, I discovered that the bump version was buggy: it searched for the version number and replaced its occurrences with the new version number. But this could also change dependency versions.

So I updated the regex and ran the bump version.

Comment thread pyproject.toml
@AntoninPoche AntoninPoche changed the title Bump version: 2.0.0 → 2.0.1 Bump version: 2.0.0 → 2.0.1 + new regex Aug 27, 2026
@Agustin-Picard Agustin-Picard self-assigned this Aug 27, 2026
@Agustin-Picard Agustin-Picard added the bug Something isn't working label Aug 27, 2026
@Agustin-Picard

Copy link
Copy Markdown
Member

Thanks for catching this Antonin! I think I've found a slightly simpler way: we do not need to specify the file for the version if it's already stored in pyproject.toml (as per https://callowayproject.github.io/bump-my-version/howtos/multiple-replacements/).

As we've discussed, I'll take over and squash the commits for a cleaner git history. I'll let you review when I'm done.

Thanks again!

Scope bump-my-version replacements so dependency version strings in pyproject.toml are not modified accidentally.

@AntoninPoche AntoninPoche left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Agustin-Picard
Agustin-Picard merged commit 801a57c into master Aug 28, 2026
25 checks passed
@Agustin-Picard
Agustin-Picard deleted the release/2.0.1 branch August 28, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants