Repository navigation
Append unnamed addl_cmds theme elements to the end of the calls - #2493
Merged
Merged
Conversation
) Unnamed elements in the `as_gt-lst:addl_cmds`, `as_flex_table-lst:addl_cmds`, `as_hux_table.gtsummary-lst:addl_cmds`, and `as_kable_extra-lst:addl_cmds` theme elements are now appended to the end of the converter calls, so users no longer need to name the call to insert after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
'as_gt-lst:addl_cmds','as_flex_table-lst:addl_cmds','as_hux_table.gtsummary-lst:addl_cmds', and'as_kable_extra-lst:addl_cmds'theme elements now accept unnamed list elements, which are appended to the end of the calls. Previously, each element had to be named after the call it should follow. (Feature request: Simpler specification of additional cmds in themes #1446)Implementation: the shared
add_expr_after()helper now appends when the element has no name. Names that don't match an existing call still error. Theme element descriptions indata-raw/gtsummary_theme_elements.csvare updated andR/sysdata.rdaregenerated.If there is an GitHub issue associated with this pull request, please provide link.
closes #1446
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()spelling::spell_check_package()runs with no spelling errors in documentationNEWS.mdwith the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).When the branch is ready to be merged into main:
🤖 Generated with Claude Code