Skip to content

dbeaver/pro#8405 adds accessibility for the filter button in the users page #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnaumov merged 3 commits into from
Aug 7, 2026
Merged

dbeaver/pro#8405 adds accessibility for the filter button in the users page #4527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8287c2a
dbeaver/pro#8405 adds accessibility for the filter button in the user…
sergeyteleshev Aug 5, 2026
f8355c9
Merge branch 'devel' into 8405-cb-user-search-filter-is-not-accessibl…
dariamarutkina Aug 6, 2026
aff92cc
Merge branch 'devel' into 8405-cb-user-search-filter-is-not-accessibl…
dariamarutkina Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...tication-administration/src/Administration/Users/UsersTable/Filters/UsersTableFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* CloudBeaver - Cloud Database Manager
* Copyright (C) 2020-2024 DBeaver Corp and others
* Copyright (C) 2020-2026 DBeaver Corp and others
*
* Licensed under the Apache License, Version 2.0.
* you may not use this file except in compliance with the License.
Expand All @@ -13,6 +13,7 @@ import { Filter, Group, IconOrImage, Loader, s, useS, useTranslate } from '@clou
import styles from './UsersTableFilters.module.css';
import { UsersTableFiltersDetails } from './UsersTableFiltersDetails.js';
import { type IUserFilters } from './useUsersTableFilters.js';
import { IconButton } from '@dbeaver/ui-kit';

interface Props {
filters: IUserFilters;
Expand All @@ -34,9 +35,14 @@ export const UsersTableFilters = observer<Props>(function UsersTableFilters({ fi
onChange={filters.setSearch}
/>
<div className={s(style, { actions: true })}>
<div className={s(style, { button: true, buttonActive: open })} onClick={() => setOpen(!open)}>
<IconButton
className={s(style, { button: true, buttonActive: open })}
size="small"
aria-label={translate('authentication_administration_users_filters_filter_label')}

@devnaumov devnaumov Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ui_filter

onClick={() => setOpen(!open)}
>
<IconOrImage className={s(style, { iconOrImage: true })} icon="filter" />
</div>
</IconButton>
</div>
</div>

Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default [
['authentication_administration_users_filters_status_enabled', 'ENABLED'],
['authentication_administration_users_filters_status_disabled', 'DISABLED'],
['authentication_administration_users_filters_status_all', 'ALL'],
['authentication_administration_users_filters_filter_label', 'Filter'],
['authentication_administration_users_empty', 'There are no users'],
['authentication_administration_users_delete_user', 'Delete user'],
['authentication_administration_users_delete_user_fail', 'Failed to delete user'],
Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default [
['authentication_administration_users_filters_status_enabled', 'ACTIVÉ'],
['authentication_administration_users_filters_status_disabled', 'DÉSACTIVÉ'],
['authentication_administration_users_filters_status_all', 'TOUS'],
['authentication_administration_users_filters_filter_label', 'Filter'],
['authentication_administration_users_empty', "Il n'y a pas d'utilisateurs"],
['authentication_administration_users_delete_user', "Supprimer l'utilisateur"],
['authentication_administration_users_delete_user_fail', "Échec de la suppression de l'utilisateur"],
Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/it.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export default [
['authentication_administration_users_filters_status_enabled', 'ENABLED'],
['authentication_administration_users_filters_status_disabled', 'DISABLED'],
['authentication_administration_users_filters_status_all', 'ALL'],
['authentication_administration_users_filters_filter_label', 'Filter'],
['authentication_administration_users_empty', 'There are no users'],
['authentication_administration_users_delete_user', 'Delete user'],
['authentication_administration_users_delete_user_fail', 'Failed to delete user'],
Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/ru.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default [
['authentication_administration_users_filters_status_enabled', 'ВКЛЮЧЕН'],
['authentication_administration_users_filters_status_disabled', 'ВЫКЛЮЧЕН'],
['authentication_administration_users_filters_status_all', 'ВСЕ'],
['authentication_administration_users_filters_filter_label', 'Фильтр'],
['authentication_administration_users_empty', 'Нет пользователей'],
['authentication_administration_users_delete_user', 'Удалить пользователя'],
['authentication_administration_users_delete_user_fail', 'Не удалось удалить пользователя'],
Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/vi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default [
['authentication_administration_users_filters_status_enabled', 'BẬT'],
['authentication_administration_users_filters_status_disabled', 'TẮT'],
['authentication_administration_users_filters_status_all', 'TẤT CẢ'],
['authentication_administration_users_filters_filter_label', 'Filter'],
['authentication_administration_users_empty', 'Không có người dùng nào'],
['authentication_administration_users_delete_user', 'Xóa người dùng'],
['authentication_administration_users_delete_user_fail', 'Xóa người dùng thất bại'],
Expand Down
1 change: 1 addition & 0 deletions webapp/packages/plugin-authentication-administration/src/locales/zh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export default [
['authentication_administration_users_filters_status_enabled', '启用'],
['authentication_administration_users_filters_status_disabled', '禁用'],
['authentication_administration_users_filters_status_all', '全部'],
['authentication_administration_users_filters_filter_label', 'Filter'],
['authentication_administration_users_empty', '无用户'],
['authentication_administration_users_delete_user', '删除用户'],
['authentication_administration_users_delete_user_fail', '删除用户失败'],
Expand Down
Loading