Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbeaver/pro#4425 [CB] Confirmation for unsaved changes in administration #4439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
dbeaver/pro#4425 [CB] Confirmation for unsaved changes in administration #4439
Changes from 7 commits
ecd4be6e4ae2c7c96aff52ebe8c4f4b3fbb07e51907d5d99cdc1d912673f0c26155100fcd783be8f52acbb43d703fdcbf2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 25 in webapp/packages/core-blocks/src/CommonDialog/ConfirmationDialog.tsx
Uh oh!
There was an error while loading. Please reload this page.
Check failure on line 47 in webapp/packages/core-blocks/src/CommonDialog/ConfirmationDialog.tsx
Check failure on line 16 in webapp/packages/core-blocks/src/index.ts
Check failure on line 17 in webapp/packages/core-blocks/src/index.ts
Check failure on line 18 in webapp/packages/core-blocks/src/index.ts
Check failure on line 19 in webapp/packages/core-blocks/src/index.ts
Check failure on line 20 in webapp/packages/core-blocks/src/index.ts
Check failure on line 21 in webapp/packages/core-blocks/src/index.ts
Check failure on line 23 in webapp/packages/core-blocks/src/index.ts
Check failure on line 24 in webapp/packages/core-blocks/src/index.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not introduce new hooks and services that are responsible for showing notification about unsaved changes.
For cases such as driver creation, Identity Providers, Secret Management and and other places where we use options panel, use the same approach we use for options panel in connection and other dialogs. Add handler to the closeTask and check everything there. As general rule, use only handlers for resolving unsaved changes issues, prevent closing by interrupting context.
All other cases should be resolved by using canDeActivate handler. Seems like we have regression in terms of unsaved changes notification when we are leaving server configuration page, you can find and fix this problem first
Check warning on line 74 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Check warning on line 74 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Check warning on line 128 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 135 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Uh oh!
There was an error while loading. Please reload this page.
Check warning on line 146 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Check warning on line 188 in webapp/packages/core-ui/src/Tabs/TabsState.tsx
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.