Optionally guide authentication before establishing boundary tunnel - #2126
Merged
Conversation
Optionally, based on ~/.myclirc settings, give the user a chance to perform a guided re-authentication to boundary before attempting to establish a tunnel. Otherwise, establishing a tunnel simply fails when the user is not authenticated. Requires moving $BOUNDARY_ADDR into the common process environment. This may work less well with some authentication methods, but was tested with OIDC. Incidentally remove some repetition of the word Boundary from error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optionally, based on
~/.myclircsettings, give the user a chance to perform a guided re-authentication to boundary before attempting to establish a tunnel.Otherwise, establishing a tunnel simply fails when the user is not authenticated.
Requires moving
$BOUNDARY_ADDRinto the common process environment.This may work less well with some authentication methods, but was tested with OIDC.
Incidentally remove some repetition of the word Boundary from error messages.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).