Skip to content

Fix misc errors #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidgiven merged 4 commits into from
Mar 7, 2026
Merged

Fix misc errors #265

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c35b84
fix(type): fixed an issue where the ptr is passed in rc2/rc3 but is e…
nick-less Feb 13, 2026
1d92921
fix(misc): replaced constant value with their most likely counterpart
nick-less Feb 13, 2026
9c0fdc7
Revert "fix(misc): replaced constant value with their most likely cou…
nick-less Feb 13, 2026
f79219d
chore(cleanup): remove now obsolete screen_putstring prototyp
nick-less Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/screen.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ zproc screen_putchar, .text.screen_putchar
jmp _call_screen
zendproc

zproc screen_putstring, .text.screen_putstring
zproc _screen_putstring, .text.screen_putstring
ldy #SCREEN_PUTSTRING
jmp _call_screen
zendproc
Expand Down
4 changes: 4 additions & 0 deletions lib/screen.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ extern void _screen_setcursor(uint16_t c);
extern uint16_t _screen_getcursor(void);
extern void screen_putchar(char c);
extern void screen_putstring(const char* s);
Comment thread
nick-less marked this conversation as resolved.
Outdated
extern void _screen_putstring(uint16_t s);
extern uint16_t screen_getchar(uint16_t timeout_cs);
extern uint8_t screen_waitchar(void);
extern void screen_scrollup(void);
Expand All @@ -22,6 +23,9 @@ extern void screen_clear_to_eol(void);
extern void screen_setstyle(uint8_t style);
extern void screen_showcursor(uint8_t show);

#define screen_putstring(x) \
_screen_putstring((uint16_t)x)

#define screen_setcursor(x, y) \
_screen_setcursor((x) | ((y)<<8))

Expand Down