You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a Holley DTZ541 where the CRC16 Algorithm is wrongly implemented by the manufacturer.
As already implemented in libsml volkszaehler/libsml#76 i did the workaround for opensml, too.
There are HLY DTZ541 with different firmware versions in the field. Since a specific version they fixed their issues. I do not know which version it is
I do not have direct access to manufacturer, product and version number in file or message parsing without major changes
there will only be an impact on malformed telegrams which crc is not valid. The users receive valid telegrams most of the time, if they receive a invalid message a additional crc is calculated. That won't affect performance and a crc hash collision for the invalid message becoming falsely valid is not very likely
If you have some suggestion I did not see feel free to give me a hint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a Holley DTZ541 where the CRC16 Algorithm is wrongly implemented by the manufacturer.
As already implemented in libsml volkszaehler/libsml#76 i did the workaround for opensml, too.
The meter often returns some invalid values which lets some calculations drift far away.
I'm using iobroker.smartmeter and hope this pr will be accepted and pulled upstream through https://github.com/Apollon77/smartmeter-obis and finally in https://github.com/Apollon77/ioBroker.smartmeter so i can enable the crc verification.
@Apollon77 ;)
added some test cases with holley sample data
feel free to review, iam happy to improve