ci: run the workflow on STACKS - #320
Merged
Merged
Conversation
The pull_request trigger filtered on "branches: [main]", so CI was skipped entirely for any pull request based on another pull request's branch. Only the publish jobs and the CLA check reported, which looks green while nothing was linted, built, or tested. Stacked pull requests are routine here, so this removed CI from the changes hardest to review. Drop the base-branch filter so every pull request is tested, and add workflow_dispatch so a run can be forced without opening a throwaway pull request against main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ecv
marked this pull request as ready for review
August 9, 2026 22:33
This was referenced Aug 9, 2026
ecv
marked this pull request as draft
August 9, 2026 23:38
ecv
marked this pull request as ready for review
August 10, 2026 00:38
ecv
enabled auto-merge
August 10, 2026 00:38
ecv
disabled auto-merge
August 10, 2026 00:38
ecv
enabled auto-merge
August 10, 2026 00:38
ecv
changed the title
privateip
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked pull requests get no CI at all right now. The
pull_requesttrigger is filtered tobranches: [main], so anything based on another PR's branch only ever shows the publish jobs and the CLA check going green. #315 and #316 have sat like that since 2026-08-08.This drops the filter and adds
workflow_dispatch. Being main-based, this PR runs its own CI, which is the proof it works.Existing stacked PRs pick it up on their next rebase.
Related to #319