Release with the shared toolchain instead of a local copy - #53
Merged
Conversation
added 2 commits
August 31, 2026 11:54
toolchain/publish.mjs here was one of four 88-97% identical copies of the same script, and this copy never got the fix that lets an interrupted release resume - the scenario the script exists for. @datocms/release-toolchain is that script, once. Notably for this repo, it reads the release branch from .changeset/config.json rather than hard-coding it, so 'master' here and 'main' elsewhere are the same code. The scripts are renamed publish -> release, publish-next -> release:next, because 'publish' is a name npm runs itself during 'npm publish'. Claude-Session: https://claude.ai/code/session_01XaYAhzmiJwysZeq1XC5xrQ
Rehearsing the resume against a real registry and a real GitHub repo turned up a bug that every copy of the old script had: killed between 'changeset publish' and 'git push', the next run reads an empty plan - the packages are on the registry and their tags are local, which is all changesets looks at - and aborts with 'there is nothing to release', leaving the commit unpushed and no GitHub release. v1.1.0 finishes that release. Claude-Session: https://claude.ai/code/session_01XaYAhzmiJwysZeq1XC5xrQ
commit: |
v1.2.0 adds a guard a package runs from prepublishOnly to refuse a hand-typed 'npm publish'. This repo does not use it: the root package.json is private, so the same slip publishes nothing. The seven single-package repos carry it, where 'npm publish' at the repo root does reach npm. The lockfile is the substantive part of this commit. Changing the spec alone left the previous SHA resolved, so 'npm ci' kept installing v1.0.0 while package.json claimed otherwise. Claude-Session: https://claude.ai/code/session_01XaYAhzmiJwysZeq1XC5xrQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toolchain/publish.mjshere was one of four 88–97% identical copies of the same~280-line script, and this copy never got the fix that lets an interrupted
release resume (
git merge-base --is-ancestor) — the exact scenario the scriptexists for.
@datocms/release-toolchainisthat script, once, shared by all eleven DatoCMS repos that publish to npm. It is
installed from the repo by git tag and never published: the
@datocmsscope onnpm is what customers install, and internal automation does not belong there.
No behaviour change is expected here. The release branch, which this repo
alone spells
master, is now read from.changeset/config.json→baseBranchrather than hard-coded — verified against this branch:
The commit subject is unchanged for anything this linked pair can actually
produce: one package alone is still named, both moving together is still
release: vX.Y.Z.What changed
toolchain/is gone (–283 lines).publish→release,publish-next→release:next. Harmless here, wherethe root
package.jsonis private, butpublishis a name npm runs itselfduring
npm publish; the single-package repos migrating next would re-entertheir own release script if they kept it.
@manypkg/get-packagesdropped — the deleted script was its only consumer.README.md,AGENTS.md,.changeset/README.mdand bothpackage READMEs.
Two things the shared script adds
vX.Y.Zwhen the repo is one package,name@versionin aworkspace) rather than hard-coded, and a step between
changeset publishandgit pushchecks that its derivation and changesets' agree — while the onlything that has happened is a publish.
visible in the release log.
https://claude.ai/code/session_01XaYAhzmiJwysZeq1XC5xrQ