Split publish.mjs into named steps - #55
Open
sistrall wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same release, same order, same behaviour. Only the shape changed.
Before: one 160-line
main(), with banner comments marking the phases.After: each phase is a function that owns its
step()heading, andmain()is the release:The file now reads in four sections: shell helpers, read-only questions about the repo, the steps, the release.
One structural change. The old
bumpingflag was tested twice, on either side of the plan read:if (bumping) { build, test, bump }… read plan …if (bumping) commit. Those five are nowprepareRelease(), so the fork inmainis one ternary naming the two cases — cut a release, or resume one that already bumped and committed.Smaller ones: the commit subject moved into
releaseSubject(plan); the tmpfile handling merged intoreadPublishPlan, so reading the plan, printing it and refusing an empty one are one function.Checked: biome clean, and the abort paths still fire (
--bogus,--tagwith no value, dirty tree). Everything past preflight would need a real release to exercise.