Collect repo automation under toolchain/ - #54
Merged
Conversation
This was referenced Aug 27, 2026
sistrall
force-pushed
the
chore/collect-repo-automation-under-toolchain
branch
from
August 28, 2026 08:03
6b1d75e to
14d3c62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
bin/publish.mjsandgenerate/both move intotoolchain/.Why
They are the same kind of thing: scripts that act on this repo, rather than code we ship. They already call each other —
publish.mjsrunssetClientVersion.ts, andwriteChangeset.tsexists only to feed a release — but nothing in the layout showed that.bin/was also a weak name for them. In several of our repos it holds files the package manager generates, mixed in with scripts we wrote, so the name does not tell you which is which.toolchain/says what the folder is for.We plan to keep replacing third-party tooling with our own scripts, so it is worth having a name for this before the pile grows.
The one real change
reExportEverything.tslocates files relative to its own path, because the build runs it from a package directory. One level deeper meant three paths needed an extra hop:Everything else resolves paths from the working directory and did not change. All 14 files are recorded as renames, so
git blamestill works.Checks
npm run build: 9/9. Then forced a rebuild of the two packages that runreExportEverything.ts— the output was byte-identical, so the new paths point at the same files.setClientVersion.tsandwriteChangeset.ts: ran, same results as before.npm run lint: clean.node toolchain/publish.mjs: loads, finds the repo root, stops at the branch check as designed.Not run:
npm test(hits the real API, CI covers it) andnpm run generate(needs the schema over the network).No changeset — nothing we publish behaves differently.
Open question
jest-helpers/stayed where it is. It is test fixture code that jest imports, not a script that does something to the repo. Easy to move if you would rather the rule be "everything that is notpackages/".