Skip to content

ci: trigger performance tests on PRs to master and allow manual dispatch - #1142

Open
NotVishesh wants to merge 2 commits into
datazip-inc:masterfrom
NotVishesh:Issue-1128
Open

ci: trigger performance tests on PRs to master and allow manual dispatch#1142
NotVishesh wants to merge 2 commits into
datazip-inc:masterfrom
NotVishesh:Issue-1128

Conversation

@NotVishesh

Copy link
Copy Markdown

Description

This PR updates the Performance Tests GitHub Actions workflow (.github/workflows/performance-test.yml) so performance tests are automatically triggered on pull requests targeting master (including when the PR branch is updated via GitHub's "Update branch" feature). It also adds manual workflow dispatch support and expands file path monitoring to include build, driver, and test files.

Fixes #1128

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Validated YAML workflow configuration and syntax locally using PyYAML (yaml.safe_load).
  • Verified pull_request target branch (master), synchronize events, and workflow_dispatch triggers.

Screenshots or Recordings

N/A

Documentation

  • Documentation Link:
  • N/A (bug fix, refactor, or test changes only)

Related PR's (If Any):

N/A

@CLAassistant

CLAassistant commented Aug 21, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@NotVishesh

Copy link
Copy Markdown
Author

Hey @nayanj98
Summary of Changes
Added pull_request trigger for master branch:
Ensures performance tests automatically trigger on PRs targeting master (including when PRs are synchronized/updated via GitHub's "Update branch" feature).
Allows GitHub Branch Protection rules for master to mandate that performance tests pass before merging.
Added workflow_dispatch trigger:
Enables manual execution of performance tests directly from the Actions tab when needed.
Expanded path filters:
Monitored paths now include Go/Java files, dependency files (go.mod, go.work, pom.xml), build configuration (Makefile, drivers/, destination/iceberg/, tests/**), and workflow files.
Permissions: Added pull-requests: read permission.

- 'Makefile'
- 'drivers/**'
- 'destination/iceberg/**'
- 'tests/**'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define &path here and reuse the same for pull_request instead of repeating files twice

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Dockerfile in the path as well.
And you can remove 'drivers/**, and 'destination/iceberg/**' from this list

@mihir-datazip

Copy link
Copy Markdown
Collaborator

@NotVishesh to test this case, you need to add a video where you do the following

  1. Start screen recording and show the state of this PR and show the Performance Tests in the checks list of the PR.
  2. Push an empty commit or a commit where unrelated files change.
  3. Now show the updated PR check list and Performance Test should still be there.

Add this video in PR description and then change the base branch to staging and I will merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge to master can happen without performance tests passing

3 participants