Repository navigation
Remove the unused python-ulid and time-machine dependencies - #6
Merged
Merged
Conversation
This was referenced Sep 17, 2026
asg017
force-pushed
the
remove-unused-dependencies
branch
from
September 25, 2026 16:53
c7647d6 to
6c4557e
Compare
Neither package is referenced anywhere: `grep -rinE 'ulid|time_machine'` over datasette_cron/, tests/, samples/, scripts/, frontend/ and the Justfile matches only these two lines in pyproject.toml. python-ulid was worse than dead weight -- it sat in [project].dependencies, so every install of this plugin pulled it in for nothing. The tests control time by injecting `now=` into `_tick` and by monkeypatching, never with time-machine. `uv tree --invert` confirms nothing else in the graph requires either, so both actually leave the environment rather than surviving as transitive deps. datasette-debug-gotham stays. It has no code references either, but it is a datasette plugin that works by being installed, and `just dev` loads it interactively -- "no references" is the expected shape for a plugin, not evidence it is unused. uv.lock is gitignored in this repo, so the refreshed lockfile is not part of this commit; `uv lock` drops exactly these two packages and bumps nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
asg017
force-pushed
the
remove-unused-dependencies
branch
from
September 25, 2026 17:30
6c4557e to
f615994
Compare
asg017
changed the base branch from
keep-ruff-out-of-markdown
to
drop-duplicate-vite-typegen
September 25, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Claude-generated PR description
Stacked on #4. Independent of #5 — no overlapping files.
Two declared dependencies are never used:
python-ulid>=3from[project].dependenciestime-machinefrom[dependency-groups].devEvidence they are unused
Tracked files, covering both the distribution name and the import name:
Whole tree (
datasette_cron/,tests/,scripts/,samples/,docs/,.github/,Justfile,README.md,NOTES.md):Only the two declarations. Nothing else in the graph needs them either, so
removing them really uninstalls them:
Post-change,
importlib.util.find_specreports both as not installed.Not removed
datasette-debug-gothamstays — it is used byjust dev, per the ownerdecision on the review ticket.
Note on the lockfile
uv.lockis git-ignored in this repo (.gitignore:13, nogit ls-filesentry), so there is no lockfile change to commit alongside
pyproject.toml. ThisPR is
pyproject.tomlonly.uv lockwas still run to confirm the resolution is sane (never hand-edited).It reported
Removed python-ulid v4.0.1,Removed time-machine v3.5.1, and aname+version comparison of every remaining package shows zero version changes
— nothing unrelated moved. The only other delta is a derived marker
simplification under
exceptiongroup, whosetyping-extensionsmarker collapsesto
python_full_version < '3.11'now that python-ulid's own constraint has leftthe graph;
exceptiongroupstays at 1.3.1 andtyping-extensionsis stillrequired by pydantic.
That
uv.lockis untracked also means Python dependency versions are notreproducible between a checkout and CI. Filed separately — not this PR's problem.
Verification
just testjust format-checkjust types-check-freshjust telemetry-doc-checkjust checkis red on this branch only because it does not include #5, whichfixes it; the failure is byte-identical before and after this change (diffed the
full output — the only difference is svelte-check's millisecond timestamps).
🤖 Generated with Claude Code