Skip to content

Remove the unused python-ulid and time-machine dependencies - #6

Merged
asg017 merged 1 commit into
drop-duplicate-vite-typegenfrom
remove-unused-dependencies
Sep 25, 2026
Merged

asg017 merged 1 commit into
drop-duplicate-vite-typegenfrom
remove-unused-dependencies

Conversation

@asg017

@asg017 asg017 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator
🤖 Claude-generated PR description

Stacked on #4. Independent of #5 — no overlapping files.

Two declared dependencies are never used:

  • python-ulid>=3 from [project].dependencies
  • time-machine from [dependency-groups].dev

Evidence they are unused

Tracked files, covering both the distribution name and the import name:

$ git grep -in 'ulid' -- . ':!uv.lock' ':!pyproject.toml'              → no output
$ git grep -inE 'time.?machine' -- . ':!uv.lock' ':!pyproject.toml'    → no output

Whole tree (datasette_cron/, tests/, scripts/, samples/, docs/,
.github/, Justfile, README.md, NOTES.md):

$ grep -rinE 'ulid|time_machine|time-machine|timemachine' . \
    --exclude-dir={node_modules,.venv,.git,dist} --exclude=uv.lock
pyproject.toml:18:    "python-ulid>=3",
pyproject.toml:37:    "time-machine",

Only the two declarations. Nothing else in the graph needs them either, so
removing them really uninstalls them:

$ uv tree --invert --package python-ulid   → python-ulid v4.0.1 └── datasette-cron
$ uv tree --invert --package time-machine  → time-machine v3.5.1 └── datasette-cron (group: dev)

Post-change, importlib.util.find_spec reports both as not installed.

Not removed

datasette-debug-gotham stays — it is used by just dev, per the owner
decision on the review ticket.

Note on the lockfile

uv.lock is git-ignored in this repo (.gitignore:13, no git ls-files
entry), so there is no lockfile change to commit alongside pyproject.toml. This
PR is pyproject.toml only.

uv lock was still run to confirm the resolution is sane (never hand-edited).
It reported Removed python-ulid v4.0.1, Removed time-machine v3.5.1, and a
name+version comparison of every remaining package shows zero version changes
— nothing unrelated moved. The only other delta is a derived marker
simplification under exceptiongroup, whose typing-extensions marker collapses
to python_full_version < '3.11' now that python-ulid's own constraint has left
the graph; exceptiongroup stays at 1.3.1 and typing-extensions is still
required by pydantic.

That uv.lock is untracked also means Python dependency versions are not
reproducible between a checkout and CI. Filed separately — not this PR's problem.

Verification

Check Before After
just test 171 passed 171 passed
just format-check GREEN (via #4) GREEN
just types-check-fresh GREEN GREEN
just telemetry-doc-check GREEN GREEN

just check is red on this branch only because it does not include #5, which
fixes it; the failure is byte-identical before and after this change (diffed the
full output — the only difference is svelte-check's millisecond timestamps).

🤖 Generated with Claude Code

Neither package is referenced anywhere: `grep -rinE 'ulid|time_machine'`
over datasette_cron/, tests/, samples/, scripts/, frontend/ and the
Justfile matches only these two lines in pyproject.toml. python-ulid was
worse than dead weight -- it sat in [project].dependencies, so every
install of this plugin pulled it in for nothing. The tests control time
by injecting `now=` into `_tick` and by monkeypatching, never with
time-machine.

`uv tree --invert` confirms nothing else in the graph requires either, so
both actually leave the environment rather than surviving as transitive
deps.

datasette-debug-gotham stays. It has no code references either, but it is
a datasette plugin that works by being installed, and `just dev` loads it
interactively -- "no references" is the expected shape for a plugin, not
evidence it is unused.

uv.lock is gitignored in this repo, so the refreshed lockfile is not part
of this commit; `uv lock` drops exactly these two packages and bumps
nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@asg017
asg017 force-pushed the remove-unused-dependencies branch from 6c4557e to f615994 Compare September 25, 2026 17:30
@asg017
asg017 changed the base branch from keep-ruff-out-of-markdown to drop-duplicate-vite-typegen September 25, 2026 17:31
@asg017
asg017 added this pull request to stack #19 September 25, 2026 18:17
@asg017
asg017 merged commit 5c6297b into main Sep 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant