Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

[feature] Authentication - #6

Open
marinofranz wants to merge 17 commits into
mainfrom
feat/auth-pages
Open

[feature] Authentication#6
marinofranz wants to merge 17 commits into
mainfrom
feat/auth-pages

Conversation

@marinofranz

@marinofranz marinofranz commented Jan 15, 2023 •
edited by CompeyDev
Loading

Copy link
Copy Markdown
Member

Context

This PR is for authentication functionality including account creations (sign ups), and account access (sign ins). The pages are intended to contain:

  • /login - Returning users, sign ins
    • Themes - Light & Dark mode
    • Back Button - Go back to the previous page
    • Action Button - Login button which is animated with an ease-in/ease-out
    • Waving Emoji - Animated waving emoji hand which goes left and right; i.e., waves
    • Mobile Responsiveness - Page should function as expected on a mobile layout
    • Captcha - Verify that the request was made by a real user
    • Functionality - Make the page actually query API endpoints and work
      • GitHub OAuth
      • Internal auth API queries
      • Handling invalid credentials
  • /register - New users, sign ups
    • Captcha - Verify that the request was made by a real user
    • Functionality - Make the page actually query API endpoints and work
      • GitHub OAuth
      • Internal create API queries

In this PR

@marinofranz marinofranz added the enhancement New feature or request label Jan 15, 2023
@marinofranz marinofranz self-assigned this Jan 15, 2023
@vercel

vercel Bot commented Jan 15, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
datalink ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 11:30PM (UTC)

@CompeyDev
CompeyDev self-requested a review January 15, 2023 12:32
CompeyDev
CompeyDev approved these changes Jan 15, 2023
View reviewed changes

@CompeyDev CompeyDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks perfect!

@CompeyDev CompeyDev changed the title feat: auth pages [feature] Authentication Jan 15, 2023
CompeyDev
CompeyDev suggested changes Jan 15, 2023
View reviewed changes

@CompeyDev CompeyDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take the following into account.

Comment thread src/pages/login.tsx
@marinofranz
marinofranz requested a review from CompeyDev January 15, 2023 13:02
@CompeyDev
CompeyDev marked this pull request as ready for review January 19, 2023 07:46
@marinofranz

marinofranz commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

This commit implements responsive design to the login page, a position for the change theme button is still undetermined.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@CompeyDev CompeyDev CompeyDev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@marinofranz marinofranz

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marinofranz @CompeyDev