Improving location support - #2001
Closed
OMWalmsley wants to merge 2 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ml-evs/bump-pydantic-final-final #2001 +/- ##
====================================================================
+ Coverage 80.02% 80.06% +0.03%
====================================================================
Files 83 83
Lines 7626 7641 +15
====================================================================
+ Hits 6103 6118 +15
Misses 1523 1523
🚀 New features to boost your workflow:
|
OMWalmsley
force-pushed
the
OMWalmsley/location-route-and-location-trait
branch
from
August 12, 2026 09:03
82cff67 to
c029337
Compare
Contributor
Author
|
This PR has been superseeded by #2002 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1970
Locations are where things are stored. Currently we are using a single string in the database to store the location and then frontend application logic on top to create a nested hierarchy. Moving forward it would be ideal to move some of this logic to the backend to prevent locations being generated from stale/deprecated data that has been stored in the frontend.
Features
GET \locationsendpoint.HasLocationattribute for all itemsExample
An example return from the endpoint is here
{"flat_locations":["Hub1 > Hub2 > Place 1","LHud One","Lab 1 > Shelf 1 > Place A","Lab 4 > Shelf 1","lab1"],"nested_locations":{"Hub1":{"Hub2":{"Place 1":{}}},"LHud One":{},"Lab 1":{"Shelf 1":{"Place A":{}}},"Lab 4":{"Shelf 1":{}},"lab1":{}}}Testing
Currently three tests have been written to test this endpoint functionality (
GET \locations).Further planned functionality
Implement this into the frontend so that it queries this endpoint instead of using frontend storage.