Skip to content

adding a button to clean all filters - #1975

Open
DianaAliabieva wants to merge 1 commit into
datalab-org:bc/refactor-dynamicdatatablefrom
Matgenix:da/clear_all_filters
Open

adding a button to clean all filters#1975
DianaAliabieva wants to merge 1 commit into
datalab-org:bc/refactor-dynamicdatatablefrom
Matgenix:da/clear_all_filters

Conversation

@DianaAliabieva

Copy link
Copy Markdown
Contributor

Adding a button to clean all filters when multiple ones are selected.
image
image
image

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (cd0b699) to head (792b43e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1975   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          83       83           
  Lines        7616     7616           
=======================================
  Hits         6114     6114           
  Misses       1502     1502           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidwaroquiers

Copy link
Copy Markdown
Member

Note to @ml-evs, we'd see the contextual actions for each row in the same "column" as the column in which this clear filter is right now.

@ml-evs ml-evs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mentioning again, could this be based on #1914 please? Otherwise looks good!

…atalab-org#1914)

Adapts the clear-filters column/button to the new columns-driven filter
setup from datalab-org#1914: extracts default-filters construction into
getDefaultFilters() so it can be reused both on created() and when
clearing, adds hasActiveFilters, and updates the 4 component tests for
the extra header column.
@DianaAliabieva
DianaAliabieva changed the base branch from main to bc/refactor-dynamicdatatable August 24, 2026 09:25
@DianaAliabieva

Copy link
Copy Markdown
Contributor Author

Just mentioning again, could this be based on #1914 please? Otherwise looks good!

Hello, the PR is ready for the check and now it is based on #1914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants