Skip to content

FAST plugin hooks - #1931

Draft
be-smith wants to merge 31 commits into
ml-evs/bump-pydantic-final-finalfrom
bes/FAST_plugin_pydanticv2
Draft

FAST plugin hooks#1931
be-smith wants to merge 31 commits into
ml-evs/bump-pydantic-final-finalfrom
bes/FAST_plugin_pydanticv2

Conversation

@be-smith

Copy link
Copy Markdown
Member

Add post-plot hooks to CycleBlock for plugin-driven metrics

Plugins can register callables on CycleBlock.post_plot_hooks. These are called after plot_cycle renders the plot. Currently takes in the an unfiltered reparse of the source file, and the cycle summary DataFrame. This is because we filter out unknown columns etc earlier in the plot_cycle so we would lose additional columns (e.g R Ohm). The reparse is only performed when a hook is registered.

Likely this structure will change with the block redesign. Reparsing seems unnecessary and these hooks could run as a separate async process.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.78947% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.95%. Comparing base (6d809c7) to head (fd3bdc3).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/apps/echem/blocks.py 35.00% 13 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           ml-evs/bump-pydantic-final-final    #1931      +/-   ##
====================================================================
- Coverage                             80.02%   79.95%   -0.08%     
====================================================================
  Files                                    83       83              
  Lines                                  7626     7663      +37     
====================================================================
+ Hits                                   6103     6127      +24     
- Misses                                 1523     1536      +13     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/models/cells.py 95.50% <100.00%> (+1.13%) ⬆️
pydatalab/src/pydatalab/apps/echem/blocks.py 77.60% <35.00%> (-3.65%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypress Bot commented Jul 17, 2026

Copy link
Copy Markdown

datalab    Run #5270

Run Properties:  status check failed Failed #5270  •  git commit cc4571c01a ℹ️: Merge fd3bdc32f71c47512ac314bac36698ec077a3ac0 into 6d809c7a5ee5f9ee2347a86ea8d0...
Project datalab
Branch Review bes/FAST_plugin_pydanticv2
Run status status check failed Failed #5270
Run duration 22m 12s
Commit git commit cc4571c01a ℹ️: Merge fd3bdc32f71c47512ac314bac36698ec077a3ac0 into 6d809c7a5ee5f9ee2347a86ea8d0...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 547
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/batchSampleFeature.cy.js • 1 failed test • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > plays with the number of rows Test Replay Screenshots

@ml-evs
ml-evs changed the base branch from main to ml-evs/bump-pydantic-final-final August 9, 2026 13:08
BenjaminCharmes and others added 27 commits August 9, 2026 14:10
Move back to descriptions in field docstrings and configure this with customised BaseModel

More model updates for pydantic v2
Fixes for routes

Chatblock patch; set default values in block

More updates for blocks
More updates for models

Fixes for models

Simplify item versioning model

Remove unecessary by_alias=True
Pydantic v2's model_json_schema() uses "$defs" instead of "definitions"
(Pydantic v1). Update the four item-information components to use the
correct key so possibleItemStatuses is no longer undefined.
@ml-evs
ml-evs force-pushed the ml-evs/bump-pydantic-final-final branch from 0969519 to 6d809c7 Compare August 9, 2026 13:10
@ml-evs
ml-evs force-pushed the bes/FAST_plugin_pydanticv2 branch from 6c72f11 to fd3bdc3 Compare August 9, 2026 13:17
@ml-evs
ml-evs force-pushed the ml-evs/bump-pydantic-final-final branch 2 times, most recently from f112cf0 to 765d3b1 Compare August 13, 2026 23:12
@ml-evs
ml-evs force-pushed the ml-evs/bump-pydantic-final-final branch 2 times, most recently from 623e1da to c075b7a Compare August 20, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants