Pass AWS service account credentials to profiles task definition in prod-eu-west - #360
Merged
Conversation
richardhallett
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Pass AWS service account credentials (
aws_service_account_keyandaws_service_account_secret) to the profiles service task definition in theprod-eu-westenvironment.Approach
Defined the necessary Terraform input variables and injected them into the ECS task definition template file data source for the profiles service.
Key Modifications
prod-eu-west/services/profiles/var.tf: Declared new input variablesaws_service_account_keyandaws_service_account_secret.prod-eu-west/services/profiles/input.tf: Updateddata.template_file.profiles_taskto pass the new service account credential variables into the task definition template.Important Technical Details
aws_service_account_keyandaws_service_account_secretmust be supplied (e.g., via.tfvarsor environment variables) during deployment.Types of changes
Reviewer, please remember our guidelines: