Skip to content

Pass AWS service account credentials to profiles task definition in prod-eu-west - #360

Merged
jrhoads merged 1 commit into
masterfrom
profiles-prod-service-key
Sep 7, 2026
Merged

Pass AWS service account credentials to profiles task definition in prod-eu-west#360
jrhoads merged 1 commit into
masterfrom
profiles-prod-service-key

Conversation

@jrhoads

@jrhoads jrhoads commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Purpose

Pass AWS service account credentials (aws_service_account_key and aws_service_account_secret) to the profiles service task definition in the prod-eu-west environment.

Approach

Defined the necessary Terraform input variables and injected them into the ECS task definition template file data source for the profiles service.

Key Modifications

  • prod-eu-west/services/profiles/var.tf: Declared new input variables aws_service_account_key and aws_service_account_secret.
  • prod-eu-west/services/profiles/input.tf: Updated data.template_file.profiles_task to pass the new service account credential variables into the task definition template.

Important Technical Details

  • The newly declared variables do not have default values, meaning valid values for aws_service_account_key and aws_service_account_secret must be supplied (e.g., via .tfvars or environment variables) during deployment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
jrhoads requested review from a team and digitaldogsbody September 4, 2026 14:54
@jrhoads
jrhoads merged commit 55b5329 into master Sep 7, 2026
84 checks passed
@jrhoads
jrhoads deleted the profiles-prod-service-key branch September 7, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants