Add AWS service account credentials for staging profiles task definition - #359
Open
jrhoads wants to merge 1 commit into
Open
Add AWS service account credentials for staging profiles task definition#359jrhoads wants to merge 1 commit into
jrhoads wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this pull request is to configure AWS service account credentials for the profiles service task definition in the staging environment.
Approach
Define new Terraform variables for the AWS service account key and secret, and forward these values into the
profiles_taskECS task definition template file.Key Modifications
stage/services/profiles/var.tf: Declaredaws_service_account_keyandaws_service_account_secretvariables.stage/services/profiles/input.tf: Addedaws_service_account_keyandaws_service_account_secretto thedata.template_file.profiles_tasktemplate variables.Important Technical Details
var.tf, their values must be supplied via the environment,.tfvars, or CI/CD secrets during Terraform execution.Types of changes
Reviewer, please remember our guidelines: