Skip to content

Add AWS service account credentials for staging profiles task definition - #359

Open
jrhoads wants to merge 1 commit into
masterfrom
profiles-service-keys
Open

Add AWS service account credentials for staging profiles task definition#359
jrhoads wants to merge 1 commit into
masterfrom
profiles-service-keys

Conversation

@jrhoads

@jrhoads jrhoads commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Purpose

The purpose of this pull request is to configure AWS service account credentials for the profiles service task definition in the staging environment.

Approach

Define new Terraform variables for the AWS service account key and secret, and forward these values into the profiles_task ECS task definition template file.

Key Modifications

  • stage/services/profiles/var.tf: Declared aws_service_account_key and aws_service_account_secret variables.
  • stage/services/profiles/input.tf: Added aws_service_account_key and aws_service_account_secret to the data.template_file.profiles_task template variables.

Important Technical Details

  • Because these variables do not have default values specified in var.tf, their values must be supplied via the environment, .tfvars, or CI/CD secrets during Terraform execution.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
jrhoads requested review from a team and digitaldogsbody September 4, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant