Skip to content

Implement source id of enrichments data model - #1582

Merged
wendelfabianchinsamy merged 13 commits into
masterfrom
implement-source-id-of-enrichments-data-model
Aug 31, 2026
Merged

Implement source id of enrichments data model#1582
wendelfabianchinsamy merged 13 commits into
masterfrom
implement-source-id-of-enrichments-data-model

Conversation

@wendelfabianchinsamy

Copy link
Copy Markdown
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy
wendelfabianchinsamy requested a review from a team August 27, 2026 06:25
Comment thread app/models/schemas/enrichment/enrichment.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, are all of the definitions here not needed? I'm pretty sure the whole attribute can be removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codycooperross that is correct. i've removed the entire block.

@wendelfabianchinsamy
wendelfabianchinsamy merged commit 853dbe4 into master Aug 31, 2026
19 checks passed
@wendelfabianchinsamy
wendelfabianchinsamy deleted the implement-source-id-of-enrichments-data-model branch August 31, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants