Allow DataciteDoi shard configuration - #1563
Open
jrhoads wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Separate Opensearch index template matching and shard configuration so that
DataciteDoireceives its own shard setting without affectingDoiorOtherDoiindices.Approach
Separate template handling for
DataciteDoi/DoiandOtherDoi, use explicit index patterns for the shared DOI indices, and introduce a configurable shard count specifically forDataciteDoi.Key Modifications
Indexable#create_templateto:dois*pattern, which also matchesdois-other*.DoiandDataciteDoi:doisdois_v1dois_v2OtherDoiusing its own alias prefix.DataciteDoisettings only toDataciteDoitemplates.NUMBER_OF_SHARDS_DATACITE_DOIconfiguration with a default value of1.DataciteDoi-specific Elasticsearch setting fornumber_of_shards.DoiandOtherDoi.Important Technical Details
DataciteDoi.settingsinherits the baseDoiindex settings and overridesnumber_of_shardsusingENV["NUMBER_OF_SHARDS_DATACITE_DOI"].OtherDoicontinues to useDoi.settings, ensuring it does not inherit the Datacite-specific shard configuration.OtherDoiindices from being unintentionally matched by the main DOI template.Types of changes
Reviewer, please remember our guidelines: